Synchronize to get re-runs to work on the latest repo.

* SIMPLE-7648: Added configuration to the ISE node definition

* Added Windows 11 node-definition from simple.

* Fixed typo

* Update ise.yaml

Updated some of the parameters of the config content; Commented all parameters which are not required to run ISE; For some parameters kept the <...> description but added a sample input to help fill them in;

.github/workflows/nd_validation.yaml

@@ -2,9 +2,11 @@ name: Node definition schema check
 
 on:
   push:
+    types: [synchronize]
     paths:
       - 'node-definitions/**/*.yaml'
   pull_request:
+    types: [synchronize]
     paths:
       - 'node-definitions/**/*.yaml'
 

node-definitions/cisco/ise/ise.yaml

@@ -32,7 +32,7 @@ sim:
       memory: 1
     efi_boot: false
 boot:
-  timeout: 1200
+  timeout: 3600
   uses_regex: false
 inherited:
   image:
@@ -50,4 +50,51 @@ inherited:
 configuration:
   generator:
     driver: null
+  provisioning:
+    files:
+      - editable: true
+        name: ise-ztp.conf
+        content: |-
+          hostname=inserthostname-here
+          ipv4_addr=<IPv4 address>
+          ipv4_mask=<IPv4 subnet>
+          ipv4_default_gw=<IPv4 gateway address>
+          # IPv6 is optional
+          #ipv6_addr=<IPv6 address>
+          #ipv6_default_gw=<IPv6 gateway address>
+          domain=cisco.com
+          primary_nameserver=<IPv4 address> <--example-8.8.8.8
+          # secondary and tertiary are optional
+          #secondary_nameserver=<IPv4 address>
+          #tertiary_nameserver=<IPv4 address>
+          primary_ntpserver=<IPv4 address or FQDN of the NTP server> <--example-time.google.com
+          #secondary and tertiary are optional
+          #secondary_ntpserver=<IPv4 address or FQDN of the NTP server>
+          #tertiary_ntpserver=<IPv4 address or FQDN of the NTP server>
+          #timezone=<timezone>
+          #ssh=<true/false>
+          username=admin
+          password=Cisc@123
+          # Public Key Authentication configuration is optional
+          #public_key=<Public Key>
+          # Repository Configuration are optional
+          #repository_name=<repository name>
+          #repository_protocol=<repository protocol>
+          #repository_server_name=<IPv4 address>
+          #repository_path=<repository path>
+          # Patch Information - optional
+          #patch=<patch filename>
+          # HotPatches Information - optional
+          #hotpatches=<hotpatch filename,comma separated list>
+          # services - optional
+          #ers=<true/false>
+          #openapi=<true/false>
+          #pxgrid=<true/false>
+          #pxGrid_Cloud=<true/false>
+          # Skipping specific checks
+          #SkipIcmpChecks=<true/false>
+          #SkipDnsChecks=<true/false>
+          #SkipNtpChecks=<true/false>
+    media_type: ext4
+    volume_name: ISE-ZTP
 schema_version: 0.0.1

node-definitions/microsoft/Windows10/Readme.md

@@ -6,7 +6,7 @@ This directory contains the following node definition:
 
 ### Image Availability
 
-VHD images can be downloaded from microsoft on a trial basis here: https://www.microsoft.com/en-us/evalcenter/evaluate-windows-10-enterprise Then the VHD image will have to be converted to a .qcow2 format. Linux qumu-img makes it easy. Documentation: https://docs.openstack.org/image-guide/convert-images.html
+VHD images can be downloaded from microsoft on a trial basis here: https://www.microsoft.com/en-us/evalcenter/evaluate-windows-10-enterprise Then the VHD image will have to be converted to a .qcow2 format. Linux `qemu-img` makes it easy. Documentation: https://docs.openstack.org/image-guide/convert-images.html
 
 ### Notes
 

node-definitions/microsoft/Windows11/Readme.md

@@ -0,0 +1,13 @@
+# Microsoft Windows 11
+
+This directory contains the following node definition:
+
+* `win11.yaml` - Microsoft Windows 11 node definition
+
+### Image Availability
+
+VHD images can be downloaded from Microsoft on a trial basis here: https://www.microsoft.com/en-us/evalcenter/evaluate-windows-11-enterprise. Then the VHD image will have to be converted to a .qcow2 format. Linux `qemu-img` makes it easy. Documentation: https://docs.openstack.org/image-guide/convert-images.html
+
+### Notes
+
+This node definition uses 2 VCPUS and 6 GB RAM.

node-definitions/microsoft/Windows11/win11.yaml

@@ -0,0 +1,71 @@
+id: win11
+general:
+  nature: server
+  read_only: false
+  description: Windows 11
+device:
+  interfaces:
+    has_loopback_zero: false
+    physical:
+      - eth0
+      - eth1
+      - eth2
+      - eth3
+      - eth4
+      - eth5
+      - eth6
+      - eth7
+    serial_ports: 1
+    default_count: 2
+ui:
+  visible: true
+  label_prefix: win11-
+  icon: host
+  label: Windows 11
+  description: |-
+    2 vCPUs 6 GB RAM
+
+    Username/Password:
+    IEUser/Passw0rd! (or whichever is set on installation)
+
+    ##### Note
+    **EXPERIMENTAL**
+
+    The -waitpkg flag is required for boot with hyperv compatibility,
+    which speeds up the node; the model setting then required disabling
+    the other features (hle,rtm,mpx) on the machine used to test this.
+sim:
+  linux_native:
+    libvirt_domain_driver: kvm
+    driver: server
+    disk_driver: sata
+    ram: 6144
+    cpus: 2
+    nic_driver: e1000
+    video:
+      model: cirrus
+      memory: 16
+    cpu_limit: 20
+    cpu_model: 'Skylake-Server,-waitpkg,-hle,-rtm,-mpx'
+    machine_type: q35
+    enable_tpm: true
+    efi_boot: true
+boot:
+  timeout: 300
+inherited:
+  image:
+    ram: true
+    cpus: true
+    data_volume: true
+    boot_disk_size: true
+    cpu_limit: true
+  node:
+    ram: true
+    cpus: true
+    data_volume: true
+    boot_disk_size: true
+    cpu_limit: true
+configuration:
+  generator:
+    driver: server
+schema_version: 0.0.1

validation_schemas/node_definition.json

@@ -182,7 +182,8 @@
                             "description": "The type of the configuration media.",
                             "enum": [
                                 "iso",
-                                "fat"
+                                "fat",
+				"ext4"
                             ]
                         },
                         "volume_name": {