paulmataruso/libredesk
1
0
Fork 0
mirror of https://github.com/abhinavxd/libredesk.git synced 2025-11-02 13:03:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: upsert user teams only when newly created user has a team.

Browse Source 
- update error msg for empty permissions
This commit is contained in:
Abhinav Raut
2025-03-25 01:41:18 +05:30
parent 8101c202fa
commit 6ac9f28a32
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/users.go
View File

@@ -205,8 +205,10 @@ func handleCreateUser(r *fastglue.Request) error {
}
// Upsert user teams.
if err := app.team.UpsertUserTeams(user.ID, user.Teams.Names()); err != nil {
return sendErrorEnvelope(r, err)
if len(user.Teams) > 0 {
if err := app.team.UpsertUserTeams(user.ID, user.Teams.Names()); err != nil {
return sendErrorEnvelope(r, err)
}
}
if user.SendWelcomeEmail {

2
internal/role/role.go
View File

@@ -134,7 +134,7 @@ func (u *Manager) Update(id int, r models.Role) error {
// validatePermissions returns true if all given permissions are valid
func (u *Manager) validatePermissions(permissions []string) error {
if len(permissions) == 0 {
return envelope.NewError(envelope.InputError, "Permissions cannot be empty", nil)
return envelope.NewError(envelope.InputError, "Select at least one permission", nil)
}
for _, perm := range permissions {
if !amodels.IsValidPermission(perm) {