paulmataruso/osmo-ggsn
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-ggsn.git synced 2025-10-23 08:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

gtp: Allow UpdatePDPContext initiated by GGSN

Browse Source 
The Update PDP Context procedure can be initiated GGSN -> SGSN, as
described in TS 29.060 7.3.3.

Related: OS#6512
Change-Id: I1c3441c71b90c5bbf6f4545484586222e6180fe1
This commit is contained in:
Pau Espin Pedrol
2024-07-29 14:29:13 +02:00
parent ea3cf1b8ae
commit 70a1d64e55
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
gtp/gtp.c
View File

@@ -1899,8 +1899,9 @@ static int gtp_update_pdp_ind(struct gsn_t *gsn, uint8_t version,
}
if (version == 1) {
/* TEID (mandatory) */
if (gtpie_gettv4(ie, GTPIE_TEI_DI, 0, &pdp->teid_gn)) {
/* TEID (mandatory SGSN->GGSN, Optional SGSN<-GGSN) */
if (gtpie_gettv4(ie, GTPIE_TEI_DI, 0, &pdp->teid_gn) &&
gsn->mode == GTP_MODE_GGSN) {
rate_ctr_inc2(gsn->ctrg, GSN_CTR_PKT_MISSING);
GTP_LOGPKG(LOGL_ERROR, peer, pack,
len, "Missing mandatory information field\n");
@@ -1954,9 +1955,10 @@ static int gtp_update_pdp_ind(struct gsn_t *gsn, uint8_t version,
pdp, GTPCAUSE_MAN_IE_MISSING);
}
/* SGSN address for user traffic (mandatory) */
/* SGSN address for user traffic (mandatory SGSN->GGSN, optional SGSN<-GGSN) */
if (gtpie_gettlv(ie, GTPIE_GSN_ADDR, 1, &pdp->gsnru.l,
&pdp->gsnru.v, sizeof(pdp->gsnru.v))) {
&pdp->gsnru.v, sizeof(pdp->gsnru.v)) &&
gsn->mode == GTP_MODE_GGSN) {
rate_ctr_inc2(gsn->ctrg, GSN_CTR_PKT_MISSING);
GTP_LOGPKG(LOGL_ERROR, peer, pack, len,
"Missing mandatory information field\n");
@@ -1966,9 +1968,10 @@ static int gtp_update_pdp_ind(struct gsn_t *gsn, uint8_t version,
}
if (version == 1) {
/* QoS (mandatory) */
/* QoS (mandatory SGSN->GGSN, optional SGSN<-GGSN) */
if (gtpie_gettlv(ie, GTPIE_QOS_PROFILE, 0, &pdp->qos_req.l,
&pdp->qos_req.v, sizeof(pdp->qos_req.v))) {
&pdp->qos_req.v, sizeof(pdp->qos_req.v)) &&
gsn->mode == GTP_MODE_GGSN) {
rate_ctr_inc2(gsn->ctrg, GSN_CTR_PKT_MISSING);
GTP_LOGPKG(LOGL_ERROR, peer, pack,
len, "Missing mandatory information field\n");
@@ -1978,7 +1981,7 @@ static int gtp_update_pdp_ind(struct gsn_t *gsn, uint8_t version,
GTPCAUSE_MAN_IE_MISSING);
}
/* TFT (conditional) */
/* TFT (conditional SGSN->GGSN, optional SGSN<-GGSN) */
if (gtpie_gettlv(ie, GTPIE_TFT, 0, &pdp->tft.l,
&pdp->tft.v, sizeof(pdp->tft.v))) {
}
@@ -2100,8 +2103,7 @@ static int gtp_update_pdp_conf(struct gsn_t *gsn, uint8_t version,
}
/* Direct Tunnel Flags */
if (gsn->mode == GTP_MODE_GGSN &&
gtpie_gettlv(ie, GTPIE_DIR_TUN_FLAGS, 0, &pdp->dir_tun_flags.l,
if (gtpie_gettlv(ie, GTPIE_DIR_TUN_FLAGS, 0, &pdp->dir_tun_flags.l,
&pdp->dir_tun_flags.v, sizeof(pdp->dir_tun_flags.v))) {
}
}
@@ -2820,8 +2822,7 @@ int gtp_decaps1c(struct gsn_t *gsn)
}
if ((gsn->mode == GTP_MODE_GGSN) &&
((pheader->type == GTP_CREATE_PDP_RSP) ||
(pheader->type == GTP_UPDATE_PDP_RSP))) {
(pheader->type == GTP_CREATE_PDP_RSP)) {
rate_ctr_inc2(gsn->ctrg, GSN_CTR_PKT_UNEXPECT);
GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
status,
@@ -2831,8 +2832,7 @@ int gtp_decaps1c(struct gsn_t *gsn)
}
if ((gsn->mode == GTP_MODE_SGSN) &&
((pheader->type == GTP_CREATE_PDP_REQ) ||
(pheader->type == GTP_UPDATE_PDP_REQ))) {
(pheader->type == GTP_CREATE_PDP_REQ)) {
rate_ctr_inc2(gsn->ctrg, GSN_CTR_PKT_UNEXPECT);
GTP_LOGPKG(LOGL_ERROR, &peer, buffer,
status,