paulmataruso/osmo-hlr
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-hlr.git synced 2025-11-04 06:03:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

mdns records: use llist_add_tail, not llist_add

Browse Source 
mslookup code isn't iterating over them in reverse anymore.

Change-Id: I8d8320e127bb3eb6c1cacface53eefd267fddab6
This commit is contained in:
Oliver Smith
2019-11-06 12:53:44 +01:00
committed by Neels Hofmeyr
parent b0c00522b0
commit 749e42902d
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/mslookup_server_mdns.c
View File

@@ -33,7 +33,7 @@ static void osmo_mslookup_server_mdns_tx(struct osmo_mslookup_server_mdns *serve
ans.domain = req->domain; ans.domain = req->domain;
rec_age = osmo_mdns_encode_txt_record(ctx, "age", "%u", result->age); rec_age = osmo_mdns_encode_txt_record(ctx, "age", "%u", result->age);
llist_add(&rec_age->list, &ans.records); llist_add_tail(&rec_age->list, &ans.records);
if (osmo_sockaddr_str_is_nonzero(&result->host_v4)) { if (osmo_sockaddr_str_is_nonzero(&result->host_v4)) {
if (osmo_sockaddr_str_to_32(&result->host_v4, &ip_v4)) { if (osmo_sockaddr_str_to_32(&result->host_v4, &ip_v4)) {
@@ -43,14 +43,14 @@ static void osmo_mslookup_server_mdns_tx(struct osmo_mslookup_server_mdns *serve
rec_ip_v4.type = OSMO_MSLOOKUP_MDNS_RECORD_TYPE_A; rec_ip_v4.type = OSMO_MSLOOKUP_MDNS_RECORD_TYPE_A;
rec_ip_v4.data = (void*)&ip_v4; rec_ip_v4.data = (void*)&ip_v4;
rec_ip_v4.length = sizeof(ip_v4); rec_ip_v4.length = sizeof(ip_v4);
llist_add(&rec_ip_v4.list, &ans.records); llist_add_tail(&rec_ip_v4.list, &ans.records);
rec_ip_v4_port = osmo_mdns_encode_txt_record(ctx, "port", "%u", result->host_v4.port); rec_ip_v4_port = osmo_mdns_encode_txt_record(ctx, "port", "%u", result->host_v4.port);
if (!rec_ip_v4_port) { if (!rec_ip_v4_port) {
errmsg = "Error encoding IPv4 port"; errmsg = "Error encoding IPv4 port";
goto clean_and_exit; goto clean_and_exit;
} }
llist_add(&rec_ip_v4_port->list, &ans.records); llist_add_tail(&rec_ip_v4_port->list, &ans.records);
} }
if (osmo_sockaddr_str_is_nonzero(&result->host_v6)) { if (osmo_sockaddr_str_is_nonzero(&result->host_v6)) {
@@ -62,14 +62,14 @@ static void osmo_mslookup_server_mdns_tx(struct osmo_mslookup_server_mdns *serve
rec_ip_v6.type = OSMO_MSLOOKUP_MDNS_RECORD_TYPE_AAAA; rec_ip_v6.type = OSMO_MSLOOKUP_MDNS_RECORD_TYPE_AAAA;
rec_ip_v6.data = (void*)&ip_v6; rec_ip_v6.data = (void*)&ip_v6;
rec_ip_v6.length = sizeof(ip_v6); rec_ip_v6.length = sizeof(ip_v6);
llist_add(&rec_ip_v6.list, &ans.records); llist_add_tail(&rec_ip_v6.list, &ans.records);
rec_ip_v6_port = osmo_mdns_encode_txt_record(ctx, "port", "%u", result->host_v6.port); rec_ip_v6_port = osmo_mdns_encode_txt_record(ctx, "port", "%u", result->host_v6.port);
if (!rec_ip_v6_port) { if (!rec_ip_v6_port) {
errmsg = "Error encoding IPv6 port"; errmsg = "Error encoding IPv6 port";
goto clean_and_exit; goto clean_and_exit;
} }
llist_add(&rec_ip_v6_port->list, &ans.records); llist_add_tail(&rec_ip_v6_port->list, &ans.records);
} }
msg = msgb_alloc(1024, __func__); msg = msgb_alloc(1024, __func__);