paulmataruso/osmo-hlr
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-hlr.git synced 2025-10-23 00:12:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

change default no-proxy reject cause to net-fail

Browse Source 
If LU has to be rejected because DGSM mechanism cannot reach the
needed HLR, then returning reject cause #17 (Network Failure)
is the most accurate and truthful description of what is actually
happening.

Reject cause #2 (IMSI unknown in HLR) is unlikely to be a good
choice: in areas where regular commercial cell services are present
alongside with experimental/adventurous Osmocom-based GSM networks,
this reject cause is acutely dangerous as described in the previous
commit, and even in areas where no regular commercial cell services
are present (the presumed intended use case for DGSM), the behavior
of commanding LU-failing phones "please don't ever again try to
connect to ANY network until the user power-cycles you" is unlikely
to be correct/desirable.  If that behavior _is_ desired, it should
be configured explicitly, not by default.

Change-Id: I557ae1d3291066a87228b5db4f2e207ea721329c
This commit is contained in:
Mychaela N. Falconia
2024-11-19 05:01:44 +00:00
committed by falconia
parent 6b5616fd36
commit ada985a0ea
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/hlr.c
View File

@@ -780,7 +780,7 @@ int main(int argc, char **argv)
g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT);
g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT);
g_hlr->reject_cause = GMM_CAUSE_PLMN_NOTALLOWED; g_hlr->reject_cause = GMM_CAUSE_PLMN_NOTALLOWED;
g_hlr->no_proxy_reject_cause = GMM_CAUSE_IMSI_UNKNOWN; g_hlr->no_proxy_reject_cause = GMM_CAUSE_NET_FAIL;
/* Init default (call independent) SS session guard timeout value */ /* Init default (call independent) SS session guard timeout value */
g_hlr->ncss_guard_timeout = NCSS_GUARD_TIMEOUT_DEFAULT; g_hlr->ncss_guard_timeout = NCSS_GUARD_TIMEOUT_DEFAULT;

2
tests/test_nodes.vty
View File

@@ -114,7 +114,7 @@ log stderr
... ...
hlr hlr
reject-cause not-found plmn-not-allowed reject-cause not-found plmn-not-allowed
reject-cause no-proxy imsi-unknown reject-cause no-proxy net-fail
store-imei store-imei
database hlr_vty_test.db database hlr_vty_test.db
no subscriber-create-on-demand no subscriber-create-on-demand