paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-10-23 16:14:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

paging: actually verify subscriber authorization

Browse Source 
Before this, any paging response would be accepted by the CN, without
checking the database whether the subscriber is in fact authorized.

The probability that a subscriber would be able to take unauthorized action
is slim, nevertheless checking authorization status with the database should
happen before we accept a connection.
This commit is contained in:
Neels Hofmeyr
2016-05-02 15:57:53 +02:00
parent 3a9c52a5dc
commit 04bfcdd6c2
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
openbsc/src/libmsc/gsm_subscriber.c
View File

@@ -132,7 +132,14 @@ int subscr_rx_paging_response(struct msgb *msg,
pr = (struct gsm48_pag_resp *)gh->data; pr = (struct gsm48_pag_resp *)gh->data;
/* Secure the connection */ /* Secure the connection */
return gsm48_secure_channel(conn, pr->key_seq, subscr_paging_sec_cb, NULL); if (subscr_authorized(conn->subscr))
return gsm48_secure_channel(conn, pr->key_seq,
subscr_paging_sec_cb, NULL);
/* Not authorized. Failure. */
subscr_paging_sec_cb(GSM_HOOK_RR_SECURITY, GSM_SECURITY_AUTH_FAILED,
msg, conn, NULL);
return -1;
} }
int msc_paging_request(struct gsm_network *network, struct gsm_subscriber *subscr, int msc_paging_request(struct gsm_network *network, struct gsm_subscriber *subscr,