paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-11-02 13:03:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

nat: The con variable is not assigned at this point

Browse Source 
Coverity pointed out that this code is logically dead. Quickly
judging the code we will forward the RSLD message anyway. Remove
the code for now and next time I work on the NAT/USSD bridge I
will have a look at the flow of the RLSD messages.

Fixes: Coverity CID 1042327
This commit is contained in:
Holger Hans Peter Freyther
2013-07-05 08:21:38 +02:00
parent 7346081ba3
commit 096dc3a466
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
openbsc/src/osmo-bsc_nat/bsc_nat.c
View File

@@ -667,11 +667,6 @@ static int forward_sccp_to_bts(struct bsc_msc_connection *msc_con, struct msgb *
goto send_to_all;
break;
case SCCP_MSG_TYPE_RLSD:
if (con && con->con_local == NAT_CON_END_USSD) {
LOGP(DNAT, LOGL_NOTICE, "RLSD for a USSD connection. Ignoring.\n");
con = NULL;
}
/* fall through */
case SCCP_MSG_TYPE_CREF:
case SCCP_MSG_TYPE_DT1:
case SCCP_MSG_TYPE_IT: