From 1a2993adb7031c7e908f478e64cf73b44419b500 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Fri, 9 Nov 2012 19:48:48 +0100 Subject: [PATCH] SMPP: fix subscriber reference leak. subscr_get_by_* is already increasing the refcount, we shouldn't do that a second time (thanks, Holger). --- openbsc/src/libmsc/smpp_openbsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/src/libmsc/smpp_openbsc.c b/openbsc/src/libmsc/smpp_openbsc.c index 4257cb62e..4a54e4780 100644 --- a/openbsc/src/libmsc/smpp_openbsc.c +++ b/openbsc/src/libmsc/smpp_openbsc.c @@ -118,7 +118,7 @@ static int submit_to_sms(struct gsm_sms **psms, struct gsm_network *net, sms = sms_alloc(); sms->source = SMS_SOURCE_SMPP; sms->smpp.sequence_nr = submit->sequence_number; - sms->receiver = subscr_get(dest); + sms->receiver = dest; strncpy(sms->dest_addr, dest->extension, sizeof(sms->dest_addr)-1); sms->sender = subscr_get_by_id(net, 1);