paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-10-23 08:12:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

smpp: Close the file descriptor when we can't accept the SMSC conn

Browse Source 
When we failed to allocate the memory or failed to register the
fd we would have leaked the file descriptor. Close the fd and
avoid the leak.
This commit is contained in:
Holger Hans Peter Freyther
2013-07-14 08:59:32 +02:00
parent c962d45669
commit 1b624ba1f6
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
openbsc/src/libmsc/smpp_smsc.c
View File

@@ -867,8 +867,10 @@ static int link_accept_cb(struct smsc *smsc, int fd,
struct sockaddr_storage *s, socklen_t s_len) struct sockaddr_storage *s, socklen_t s_len)
{ {
struct osmo_esme *esme = talloc_zero(smsc, struct osmo_esme); struct osmo_esme *esme = talloc_zero(smsc, struct osmo_esme);
if (!esme) if (!esme) {
close(fd);
return -ENOMEM; return -ENOMEM;
}
smpp_esme_get(esme); smpp_esme_get(esme);
esme->own_seq_nr = rand(); esme->own_seq_nr = rand();
@@ -880,6 +882,7 @@ static int link_accept_cb(struct smsc *smsc, int fd,
esme->wqueue.bfd.when = BSC_FD_READ; esme->wqueue.bfd.when = BSC_FD_READ;
if (osmo_fd_register(&esme->wqueue.bfd) != 0) { if (osmo_fd_register(&esme->wqueue.bfd) != 0) {
close(fd);
talloc_free(esme); talloc_free(esme);
return -EIO; return -EIO;
} }