paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-10-23 16:14:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

nat: Use memcmp for the token on the USSD interface as well

Browse Source 
This is similar to the token on the A-interface. There are no more
token based authentication in the NAT.
This commit is contained in:
Holger Hans Peter Freyther
2013-04-22 10:54:02 +02:00
parent ab22335378
commit 2bc90c274d
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
openbsc/src/osmo-bsc_nat/bsc_ussd.c
View File

@@ -159,12 +159,13 @@ static void ussd_auth_con(struct tlv_parsed *tvp, struct bsc_nat_ussd_con *conn)
token = (const char *) TLVP_VAL(tvp, IPAC_IDTAG_UNITNAME);
len = TLVP_LEN(tvp, IPAC_IDTAG_UNITNAME);
if (strncmp(conn->nat->ussd_token, token, len) != 0) {
LOGP(DNAT, LOGL_ERROR, "Wrong USSD token by client: %d\n",
conn->queue.bfd.fd);
bsc_nat_ussd_destroy(conn);
return;
}
/* last byte should be a NULL */
if (strlen(conn->nat->ussd_token) != len - 1)
goto disconnect;
/* compare everything including the null byte */
if (memcmp(conn->nat->ussd_token, token, len) != 0)
goto disconnect;
/* it is authenticated now */
if (conn->nat->ussd_con && conn->nat->ussd_con != conn)
@@ -174,6 +175,12 @@ static void ussd_auth_con(struct tlv_parsed *tvp, struct bsc_nat_ussd_con *conn)
osmo_timer_del(&conn->auth_timeout);
conn->authorized = 1;
conn->nat->ussd_con = conn;
return;
disconnect:
LOGP(DNAT, LOGL_ERROR, "Wrong USSD token by client: %d\n",
conn->queue.bfd.fd);
bsc_nat_ussd_destroy(conn);
}
static void ussd_start_auth(struct bsc_nat_ussd_con *conn)