paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-11-03 21:43:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

db: fix Smatch warnings

Browse Source 
/home/laforge/projects/git/openbsc/openbsc/src/libmsc/db.c +254 db_fini(6) info: redundant null check on db_dirname calling free()
/home/laforge/projects/git/openbsc/openbsc/src/libmsc/db.c +256 db_fini(8) info: redundant null check on db_basename calling free()
/home/laforge/projects/git/openbsc/openbsc/src/libmsc/db.c +280 db_create_subscriber(20) warn: variable dereferenced before check 'subscr'
This commit is contained in:
Harald Welte
2011-07-16 13:22:57 +02:00
parent 46324ccfcd
commit 2c5f4c635a
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
openbsc/src/libmsc/db.c
View File

@@ -250,10 +250,8 @@ int db_fini()
dbi_conn_close(conn); dbi_conn_close(conn);
dbi_shutdown(); dbi_shutdown();
if (db_dirname) free(db_dirname);
free(db_dirname); free(db_basename);
if (db_basename)
free(db_basename);
return 0; return 0;
} }
@@ -276,9 +274,9 @@ struct gsm_subscriber *db_create_subscriber(struct gsm_network *net, char *imsi)
} }
subscr = subscr_alloc(); subscr = subscr_alloc();
subscr->flags |= GSM_SUBSCRIBER_FIRST_CONTACT;
if (!subscr) if (!subscr)
return NULL; return NULL;
subscr->flags |= GSM_SUBSCRIBER_FIRST_CONTACT;
result = dbi_conn_queryf(conn, result = dbi_conn_queryf(conn,
"INSERT INTO Subscriber " "INSERT INTO Subscriber "
"(imsi, created, updated) " "(imsi, created, updated) "