paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-11-03 13:33:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

osmo-bsc: rename calling_addr to msc_addr

Browse Source 
The variable name "calling_addr" is not very expressive. Change
the variable name to "msc_addr".

Change-Id: I3a43880d4172063e78bfef1556dbb037f20a9a99
This commit is contained in:
Philipp Maier
2017-06-30 16:49:06 +02:00
committed by Neels Hofmeyr
parent 88824c7c7d
commit 51442a7886
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/osmo-bsc/osmo_bsc_sigtran.c
View File

@@ -103,15 +103,15 @@ void osmo_bsc_sigtran_tx_reset_ack(struct bsc_msc_data *msc)
} }
/* Find an MSC by its sigtran point code */ /* Find an MSC by its sigtran point code */
static struct bsc_msc_data *get_msc_by_addr(struct osmo_sccp_addr *calling_addr) static struct bsc_msc_data *get_msc_by_addr(struct osmo_sccp_addr *msc_addr)
{ {
struct bsc_msc_data *msc; struct bsc_msc_data *msc;
llist_for_each_entry(msc, msc_list, entry) { llist_for_each_entry(msc, msc_list, entry) {
if (memcmp(calling_addr, &msc->a.msc_addr, sizeof(*calling_addr)) == 0) if (memcmp(msc_addr, &msc->a.msc_addr, sizeof(*msc_addr)) == 0)
return msc; return msc;
} }
LOGP(DMSC, LOGL_ERROR, "Unable to find MSC data under address: %s\n", osmo_sccp_addr_dump(calling_addr)); LOGP(DMSC, LOGL_ERROR, "Unable to find MSC data under address: %s\n", osmo_sccp_addr_dump(msc_addr));
return NULL; return NULL;
} }
@@ -131,9 +131,9 @@ static int handle_data_from_msc(int conn_id, struct msgb *msg)
} }
/* Sent unitdata to MSC, use the point code to determine which MSC it is */ /* Sent unitdata to MSC, use the point code to determine which MSC it is */
static int handle_unitdata_from_msc(struct osmo_sccp_addr *calling_addr, struct msgb *msg) static int handle_unitdata_from_msc(struct osmo_sccp_addr *msc_addr, struct msgb *msg)
{ {
struct bsc_msc_data *msc = get_msc_by_addr(calling_addr); struct bsc_msc_data *msc = get_msc_by_addr(msc_addr);
int rc = -EINVAL; int rc = -EINVAL;
if (msc) { if (msc) {
@@ -141,7 +141,7 @@ static int handle_unitdata_from_msc(struct osmo_sccp_addr *calling_addr, struct
rc = bsc_handle_udt(msc, msg, msgb_l2len(msg)); rc = bsc_handle_udt(msc, msg, msgb_l2len(msg));
} else } else
LOGP(DMSC, LOGL_NOTICE, "incoming unitdata data from unknown remote address: %s\n", LOGP(DMSC, LOGL_NOTICE, "incoming unitdata data from unknown remote address: %s\n",
osmo_sccp_addr_dump(calling_addr)); osmo_sccp_addr_dump(msc_addr));
return rc; return rc;
} }