paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-11-04 05:53:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

nat: Access data_ptr after we have checked the length

Browse Source
This commit is contained in:
Holger Hans Peter Freyther
2012-01-10 13:04:40 +01:00
parent c5df08b388
commit 5d2a30a83c
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
openbsc/src/osmo-bsc_nat/bsc_nat_utils.c
View File

@@ -1026,15 +1026,15 @@ static struct msgb *rewrite_sms(struct bsc_nat *nat, struct msgb *msg,
return NULL; return NULL;
} }
/* look into the phone number */
if ((data_ptr[0] & 0x01) != 1)
return NULL;
if (data_len < 3) { if (data_len < 3) {
LOGP(DNAT, LOGL_ERROR, "SMS-SUBMIT is too short.\n"); LOGP(DNAT, LOGL_ERROR, "SMS-SUBMIT is too short.\n");
return NULL; return NULL;
} }
/* look into the phone number */
if ((data_ptr[0] & 0x01) != 1)
return NULL;
dest_len = data_ptr[2]; dest_len = data_ptr[2];
if (data_len < dest_len + 3 || dest_len < 2) { if (data_len < dest_len + 3 || dest_len < 2) {
LOGP(DNAT, LOGL_ERROR, "SMS-SUBMIT can not have TP-DestAddr.\n"); LOGP(DNAT, LOGL_ERROR, "SMS-SUBMIT can not have TP-DestAddr.\n");