paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-11-02 13:03:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

mgw: Rearrange last steps of CRCX and MDCX

Browse Source 
Make code in CRCX and MDCX look closer, since it is really doing the
same.
Move the dummy ping code after everything has been done correctly, since
the ping is just a side effect of the conn being created.

Change-Id: I42acda16cb2d59a9b7aae06b7584d4dfc1e91f9e
This commit is contained in:
Pau Espin Pedrol
2025-03-10 17:15:41 +01:00
parent c3ff38ee4c
commit 8b23fb916a
1 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/libosmo-mgcp/mgcp_protocol.c
View File

@@ -782,8 +782,11 @@ static struct msgb *handle_create_con(struct mgcp_request_data *rq)
}
}
LOGPCONN(conn, DLMGCP, LOGL_DEBUG,
"CRCX: Creating connection: port: %u\n", conn_rtp->end.local_port);
mgcp_endp_update(endp);
LOGPCONN(conn, DLMGCP, LOGL_NOTICE,
"CRCX: connection successfully created: %s\n", mgcp_conn_dump(conn));
rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_SUCCESS));
/* Send dummy packet, see also comments in mgcp_keepalive_timer_cb() */
OSMO_ASSERT(trunk->keepalive_interval >= MGCP_KEEPALIVE_ONCE);
@@ -791,11 +794,6 @@ static struct msgb *handle_create_con(struct mgcp_request_data *rq)
trunk->keepalive_interval != MGCP_KEEPALIVE_NEVER)
send_dummy(endp, conn_rtp);
LOGPCONN(conn, DLMGCP, LOGL_NOTICE,
"CRCX: connection successfully created\n");
rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_SUCCESS));
mgcp_endp_update(endp);
/* NOTE: Only in the virtual trunk we allow dynamic endpoint names */
bool add_epname = rq->wildcarded && trunk->trunk_type == MGCP_TRUNK_VIRTUAL;
return create_response_with_sdp(endp, conn_rtp, "CRCX", pdata->trans, add_epname, true);
@@ -1006,9 +1004,11 @@ static struct msgb *handle_modify_con(struct mgcp_request_data *rq)
}
}
/* modify */
LOGPCONN(conn, DLMGCP, LOGL_DEBUG,
"MDCX: modified conn:%s\n", mgcp_conn_dump(conn));
mgcp_endp_update(endp);
LOGPCONN(conn, DLMGCP, LOGL_NOTICE,
"MDCX: connection successfully modified: %s\n", mgcp_conn_dump(conn));
rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_SUCCESS));
/* Send dummy packet, see also comments in mgcp_keepalive_timer_cb() */
OSMO_ASSERT(trunk->keepalive_interval >= MGCP_KEEPALIVE_ONCE);
@@ -1016,11 +1016,6 @@ static struct msgb *handle_modify_con(struct mgcp_request_data *rq)
trunk->keepalive_interval != MGCP_KEEPALIVE_NEVER)
send_dummy(endp, conn_rtp);
rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_SUCCESS));
LOGPCONN(conn, DLMGCP, LOGL_NOTICE,
"MDCX: connection successfully modified\n");
mgcp_endp_update(endp);
return create_response_with_sdp(endp, conn_rtp, "MDCX", pdata->trans, false, false);
error3:
return create_err_response(endp, endp, error_code, "MDCX", pdata->trans);