paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-11-03 21:43:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

subscriber: Address coverity warning and truncate the IMSI

Browse Source 
The IMSI can only be 15 characters in length, our define gives
us a length of 17. This means we have place for two NULs. Use
strncpy and make sure it is null-terminated.

Fixes: Coverity CID 1040707
This commit is contained in:
Holger Hans Peter Freyther
2013-12-12 15:28:43 +01:00
parent 7672db33bd
commit a5ddf489e1
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
openbsc/src/libbsc/gsm_subscriber_base.c
View File

@@ -104,7 +104,8 @@ struct gsm_subscriber *subscr_get_or_create(struct gsm_network *net,
if (!subscr) if (!subscr)
return NULL; return NULL;
strcpy(subscr->imsi, imsi); strncpy(subscr->imsi, imsi, GSM_IMSI_LENGTH);
subscr->imsi[GSM_IMSI_LENGTH - 1] = '\0';
subscr->net = net; subscr->net = net;
return subscr; return subscr;
} }