paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-10-30 19:43:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

in gsm8_rx_mm_auth_resp(): call sec_operation.cb() instead of finish_lu() directly

Browse Source
This commit is contained in:
Neels Hofmeyr
2016-03-22 19:53:36 +01:00
parent 4b3b13e10c
commit d025a3cfbb
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
openbsc/src/libmsc/gsm_04_08.c
View File

@@ -1121,6 +1121,7 @@ static int gsm48_rx_mm_auth_resp(struct gsm_subscriber_connection *conn, struct
struct gsm48_hdr *gh = msgb_l3(msg); struct gsm48_hdr *gh = msgb_l3(msg);
struct gsm48_auth_resp *ar = (struct gsm48_auth_resp*) gh->data; struct gsm48_auth_resp *ar = (struct gsm48_auth_resp*) gh->data;
struct gsm_network *net = conn->network; struct gsm_network *net = conn->network;
gsm_cbfn *cb;
DEBUGP(DMM, "MM AUTHENTICATION RESPONSE (sres = %s): ", DEBUGP(DMM, "MM AUTHENTICATION RESPONSE (sres = %s): ",
osmo_hexdump(ar->sres, 4)); osmo_hexdump(ar->sres, 4));
@@ -1131,11 +1132,11 @@ static int gsm48_rx_mm_auth_resp(struct gsm_subscriber_connection *conn, struct
return -EIO; return -EIO;
} }
cb = conn->sec_operation->cb;
/* Validate SRES */ /* Validate SRES */
if (memcmp(conn->sec_operation->atuple.sres, ar->sres,4)) { if (memcmp(conn->sec_operation->atuple.sres, ar->sres,4)) {
int rc; int rc;
gsm_cbfn *cb = conn->sec_operation->cb;
DEBUGPC(DMM, "Invalid (expected %s)\n", DEBUGPC(DMM, "Invalid (expected %s)\n",
osmo_hexdump(conn->sec_operation->atuple.sres, 4)); osmo_hexdump(conn->sec_operation->atuple.sres, 4));
@@ -1156,13 +1157,10 @@ static int gsm48_rx_mm_auth_resp(struct gsm_subscriber_connection *conn, struct
conn->sec_operation->atuple.kc, 8, 0); conn->sec_operation->atuple.kc, 8, 0);
/* Only authentication requested, and we're done. */ /* Only authentication requested, and we're done. */
if (!conn->loc_operation) { if (!cb)
LOGP(DMM, LOGL_ERROR, "Received authentication response, but no" return 0;
" location update operation pending for subscriber %s\n", return cb(GSM_HOOK_RR_SECURITY, GSM_SECURITY_SUCCEEDED,
subscr_name(conn->subscr)); NULL, conn, conn->sec_operation->cb_data);
return -1;
}
return finish_lu(conn);
} }
/* Receive a GSM 04.08 Mobility Management (MM) message */ /* Receive a GSM 04.08 Mobility Management (MM) message */