paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-11-02 13:03:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

[rsl] Move rf channel release scheduling to a new method

Browse Source 
The current channel release has a couple of issues we will
need to fix in a set of upcoming commits.

The issues include:
    1.) sending release twice
    2.) reassigning the channel inbetween the relase..
This commit is contained in:
Holger Hans Peter Freyther
2010-04-08 22:39:34 +02:00
parent a4b16658d5
commit dbc5fae576
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
openbsc/src/abis_rsl.c
View File

@@ -1258,6 +1258,14 @@ static int rsl_rx_rll_err_ind(struct msgb *msg)
return 0; return 0;
} }
static void rsl_handle_release(struct gsm_lchan *lchan)
{
/* we can now releae the channel on the BTS/Abis side */
/* FIXME: officially we need to start T3111 and wait for
* some grace period */
rsl_rf_chan_release(lchan);
}
/* ESTABLISH INDICATION, LOCATION AREA UPDATE REQUEST /* ESTABLISH INDICATION, LOCATION AREA UPDATE REQUEST
0x02, 0x06, 0x02, 0x06,
0x01, 0x20, 0x01, 0x20,
@@ -1309,20 +1317,14 @@ static int abis_rsl_rx_rll(struct msgb *msg)
msg->lchan->sapis[rllh->link_id & 0x7] = LCHAN_SAPI_UNUSED; msg->lchan->sapis[rllh->link_id & 0x7] = LCHAN_SAPI_UNUSED;
rll_indication(msg->lchan, rllh->link_id, rll_indication(msg->lchan, rllh->link_id,
BSC_RLLR_IND_REL_IND); BSC_RLLR_IND_REL_IND);
/* we can now releae the channel on the BTS/Abis side */ rsl_handle_release(msg->lchan);
/* FIXME: officially we need to start T3111 and wait for
* some grace period */
rsl_rf_chan_release(msg->lchan);
break; break;
case RSL_MT_REL_CONF: case RSL_MT_REL_CONF:
/* BTS informs us of having received UA from MS, /* BTS informs us of having received UA from MS,
* in response to DISC that we've sent earlier */ * in response to DISC that we've sent earlier */
DEBUGPC(DRLL, "RELEASE CONFIRMATION\n"); DEBUGPC(DRLL, "RELEASE CONFIRMATION\n");
msg->lchan->sapis[rllh->link_id & 0x7] = LCHAN_SAPI_UNUSED; msg->lchan->sapis[rllh->link_id & 0x7] = LCHAN_SAPI_UNUSED;
/* we can now releae the channel on the BTS/Abis side */ rsl_handle_release(msg->lchan);
/* FIXME: officially we need to start T3111 and wait for
* some grace period */
rsl_rf_chan_release(msg->lchan);
break; break;
case RSL_MT_ERROR_IND: case RSL_MT_ERROR_IND:
rc = rsl_rx_rll_err_ind(msg); rc = rsl_rx_rll_err_ind(msg);