Commit Graph

5437 Commits

Author SHA1 Message Date
Daniel Willmann
2f5cc8abe0 tests/sgsn: Fix compilation of sgsn_test
The sgsn test still fails, but at least it is compiling again..
2016-03-03 16:19:10 +01:00
Daniel Willmann
ba47b525ff sgsn_libgtp: Use the address provided by the GGSN for RAB activation 2016-03-03 16:19:10 +01:00
Daniel Willmann
cf1707af7f gprs: Fix some misleading comments 2016-03-03 16:19:10 +01:00
Daniel Willmann
d6d0d8b86f WIP: Wait for radio bearer before sending pdp context accept 2016-03-03 16:19:10 +01:00
Daniel Willmann
38137e84f7 HACK: ranap_decode_rab_setupormodifieditemies crashes so disable it 2016-03-03 16:19:10 +01:00
Daniel Willmann
82724653e7 sgsn_iu: RABAssignment response is an Outcome, not a Successful one 2016-03-03 16:19:10 +01:00
Daniel Willmann
da8d9bc355 gprs_gmm: Fix bit mask when determining update/attach type
Bit 4 is reserved in 3GPP TS 04.08 so exclude it from the type.

In 3GPP TS 24.008 it indicates if a follow-on request is pending by the
MS, but only in Iu mode. According to the spec it is not required to
react to that request with a follow-on proceed so this field can be
ignored for now.

See 3GPP TS 24.008 Ch. 4.4:
"Unless it has specific permission from the network (follow-on proceed)
the mobile station side should await the release of the RR connection
used for a MM specific procedure before a new MM specific procedure or
MM connection establishment is started."

as well as Ch. 4.4.4.6:
"If the network wishes to prolong the RR connection to allow the mobile
station to initiate MM connection establishment (for example if the
mobile station has indicated in the LOCATION UPDATING REQUEST that it
has a follow-on request pending) the network shall send "follow on
proceed" in the LOCATION UPDATING ACCEPT and start timer T3255."
2016-03-03 16:19:10 +01:00
Neels Hofmeyr
c59e52a6aa doc: rename nitb graph to bsc, add msc graph
NITB is already gone from this branch. We may even resurrect it, but I prefer
to name the realms 'libmsc' and 'libbsc', hence the nitb graph is the BSC graph
now. Also add a libmsc graph.
2016-03-03 16:19:10 +01:00
Neels Hofmeyr
24c4af1d82 doc: add lists to nitb graph 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
f918920d65 cscn: use iu_tx for msc_ifaces.iu_cs. some #include cosmetics. 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
292f1ce533 mscsplit: fix compilation and comments. move msc_api.h. 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
23e7f28c5c mscsplit: getting grips on header scopes 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
243c7cb044 msc: clarify msc_api and msc_ifaces scopes 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
cf2591f6fc rename IFACE_IUCS to IFACE_IU 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
6a2d8985bf cscn: rename msc_api 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
c6794eed1d cscn: some file moves/renames 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
7a70a4f52a cscn wip: direct dtap responses to IuCS 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
c6172a320b cscn: fix missing network backpointer 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
5280ed558c cscn: own talloc root and gsm_network instance; misc.
Heading towards a sovereign CSCN.
2016-03-03 16:19:10 +01:00
Neels Hofmeyr
b36b910366 mscsplit: exclude some more vty nodes 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
b47e52c958 cosmetic: remove unused extern. 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
267f6c7e0d introduce vty CSCN_NODE, cosmetically. 2016-03-03 16:19:10 +01:00
Neels Hofmeyr
5e47b1a1d3 mscplit: try to clarify root talloc ctx and global gsm_network.
The aim is to allow osmo-cscn to pass its own root talloc context and
global gsm_network struct instance cleanly. This may stir up some old and
dusty globals, but I hope it's for the better, since not all is a BSC.

To ensure that a global gsm_network pointer for the bsc_vty is set, have it as
argument to bsc_vty_init(). The vty configuration commands are added only after
bsc_vty_init(), which are needed to configure the network struct. So split up
the bsc_bootstrap_network() function into bsc_network_init() to allocate a
gsm_struct, and bsc_network_configure() to read the config file once the vty
commands are in place. In this way, no global bsc_gsmnet pointer is needed for
the bsc vty. The atomic super glue is dissolved and osmo-cscn will be allowed
to have a different name for it.

Admitted, it's still called the bsc_vty, but a split thereof is probably coming
soon, because the CSCN doesn't want any of the BSC nor BTS specific vty
commands.
2016-03-03 16:19:09 +01:00
Neels Hofmeyr
b9e5403ef4 mscsplit: remove bts and lchan pointers from libmsc
The diff between this and master will probably need a lot of review and fixes.
The current state does compile, but I expect pretty much everything to be
broken now. Future development will reinstate proper functionality piecemeal.

The first goal is to get basic signalling to work, then SMS. The voice control
(RTP) is completely disabled now (see "#if BEFORE_MSCSPLIT") and will be fixed
last AFAICT.
2016-03-03 16:19:09 +01:00
Neels Hofmeyr
b6769b99de cosmetics: link_id=42, s/Iu-CS/IuCS, debug logs.
Until I get the proper link id from the SUA SAP, make sure we recognise it
as hardcoded by setting it to 42.
2016-03-03 16:19:09 +01:00
Neels Hofmeyr
39daffd7a5 cscn: allocate IuCS conn, properly return rc. 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
71d1e17e5e cscn: call msc_compl_l3() from subscr_conn_allocate_iu()
Pubish msc_compl_l3() decl in new file libmsc/msc_api.h (but see comment).

Call msc_compl_l3() when establishing a subscriber connection for IuCS.

Remove bts from subscr_conn_allocate_iu() signature, use network, link_id and
conn_id instead.

Move subscr_conn_allocate_iu() to the top of the file, because it semantically
belongs before subscr_conn_lookup_iu().
2016-03-03 16:19:09 +01:00
Neels Hofmeyr
2c9e65051c cscn: default to osmo-cscn.cfg, not opencscn.cfg 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
a2ce4aa615 cscn: move gsm0408_rcvmsg_iucs() decl to proper place.
Add noinst-header iu_cs.h and move the gsm0408_rcvmsg_iucs() declaration
there.
2016-03-03 16:19:09 +01:00
Neels Hofmeyr
ee1541d504 put Iu-common and Iu-CS stuff in proper places
Add libiu to contain the parts used by both Iu-CS (in osmo-cscn) and Iu-PS (in
gprs) into libiu. It's rather thin and may make sense to move to osmo-iuh
altogether, eventually.

iu.c is half moved to libiu/, and half to osmo-cscn/iu_cs.c.
2016-03-03 16:19:09 +01:00
Neels Hofmeyr
9dcae17866 wip 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
c2c5176328 todo / #if 0 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
a2c182df6d minor fixes 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
070f673b12 func declaration, comments 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
e2a10dbe35 fix: it's called msgb.dst. 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
bf30ec26e5 wip 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
dcbc852125 Indicate A-interface for new A subscr-conn. 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
48e091ea2b Add some Iu-CS functions (in the wrong place though, wip) 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
712074cb17 cosmetic: a rename, comments.
Rename conn_ctx_list -> ue_conn_ctx_list.
Indicate Iu-CS 'siblings' for a couple of functions.
Tweak/add comments.
2016-03-03 16:19:09 +01:00
Neels Hofmeyr
a34aedf7f9 Add Iu-CS indicator to struct gsm_subscriber_connection.
Introduce enum interface_type and gsm_subscriber_connection.via_iface to
distinguish between A-interface and Iu-CS-interface connections.

Add gsm_subscriber_connection.iu.link_id and iu.conn_id.
2016-03-03 16:19:09 +01:00
Neels Hofmeyr
2e5c13129d log level: DIUCS = debug 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
da5b3fcd32 wip (reminders to self, whitespace) 2016-03-03 16:19:09 +01:00
Neels Hofmeyr
5291ee5c16 make osmo-cscn compile and receive first Iu-CS buf (and log it only) 2016-03-03 16:19:08 +01:00
Neels Hofmeyr
5773987881 iu_init: add addr and port args 2016-03-03 16:19:08 +01:00
Neels Hofmeyr
836b904e77 add DIUCS debug id 2016-03-03 16:19:08 +01:00
Neels Hofmeyr
444d50b77f various small fixes 2016-03-03 16:19:08 +01:00
Neels Hofmeyr
b3b8ccfa54 sai arg back to pointer 2016-03-03 16:19:08 +01:00
Neels Hofmeyr
231aa60ce4 some fixes 2016-03-03 16:19:08 +01:00
Neels Hofmeyr
8b713f817d generalize rab_act for ps and cs 2016-03-03 16:19:08 +01:00
Neels Hofmeyr
ce3b41fdb6 move struct ue_conn_ctx to header 2016-03-03 16:19:08 +01:00