Compare commits

...

2 Commits

Author SHA1 Message Date
Gerrit User 1000004
60882f2161 Update patch set 2
Patch Set 2: -Code-Review

(1 comment)

Patch-set: 2
Label: Code-Review=0, 733a2cb259c808b0519b7980d99dd26e34810cfb
2025-10-21 20:25:37 +00:00
Gerrit User 1000004
14d1ee37be Update patch set 2
Patch Set 2: Code-Review+1

(4 comments)

Patch-set: 2
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 955ca145377db7157873a1c2c1ad33913262e86d
Attention: {"person_ident":"Gerrit User 1000230 \u003c1000230@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
2025-10-21 20:25:11 +00:00

View File

@@ -53,6 +53,23 @@
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "22d57bdb_3501e12c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2025-10-21T20:25:37Z",
"side": 1,
"message": "I\u0027d still want the unresolved comments to be adressed somehow.",
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -170,6 +187,24 @@
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "7a37b698_3f7988da",
"filename": "src/libosmo-mgcp/mgcp_network.c",
"patchSetId": 2
},
"lineNbr": 691,
"author": {
"id": 1000004
},
"writtenOn": "2025-10-21T20:25:11Z",
"side": 1,
"message": "Done",
"parentUuid": "43c79097_a22c5d4b",
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -241,6 +276,30 @@
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "1e1de471_7286ebf5",
"filename": "src/libosmo-mgcp/mgcp_network.c",
"patchSetId": 2
},
"lineNbr": 698,
"author": {
"id": 1000004
},
"writtenOn": "2025-10-21T20:25:11Z",
"side": 1,
"message": "Done",
"parentUuid": "15786ea3_af80d169",
"range": {
"startLine": 698,
"startChar": 13,
"endLine": 698,
"endChar": 36
},
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -357,6 +416,24 @@
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "a0cf7996_312b9e4a",
"filename": "src/libosmo-mgcp/mgcp_network.c",
"patchSetId": 2
},
"lineNbr": 1660,
"author": {
"id": 1000004
},
"writtenOn": "2025-10-21T20:25:11Z",
"side": 1,
"message": "Done",
"parentUuid": "bc231742_388288f0",
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -392,6 +469,24 @@
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "dfea6621_0f340ae1",
"filename": "src/libosmo-mgcp/mgcp_network.c",
"patchSetId": 2
},
"lineNbr": 1661,
"author": {
"id": 1000004
},
"writtenOn": "2025-10-21T20:25:11Z",
"side": 1,
"message": "Done",
"parentUuid": "72bff7db_64557059",
"revId": "bf44c8c782b83deb8c1dba7e6bc91f628313f76f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {