mirror of
https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git
synced 2025-11-02 13:03:33 +00:00
bc0346e080
The codec negotiation via SDP is currently in a neglected state. Also osmo-mgw does some kind of codec decision wile the SDP is parsed, the result is information for one codec, even when there are multiple codecs negotiated. This is problematic because we loose all information about alternate codecs while we parse. This should be untangled and the information should be presevered. Also we are not really capable picking a default. Wehen we do not supply any codec information (not even LCO), then we should pick a sane default codec. - separate the codec decision from the sdp parser and concentrate codec related code in a separate c file - add support for multiple codecs in one SDP negotiation - do not initalize "magic" codec defaults during conn allocation - do not allow invalid payload types, especially not 255. When someone tries to select an invalid payload type, do not fail hard, just pick a sane default. - handle the codec decision in protocol.c, pick a sane default codec when no (valid) codec has been negotiated (no LCO, no SDP) Change-Id: If730d022ba6bdb217ad4e20b3fbbd1114dbb4b8f Closes: OS#2658 Related: OS#3114 Related: OS#2728
90 lines
3.0 KiB
C
90 lines
3.0 KiB
C
/* MGCP common implementations.
|
|
* These are used in libosmo-mgcp as well as libosmo-mgcp-client.
|
|
* To avoid interdependency, these are implemented in .h file only. */
|
|
|
|
/*
|
|
* (C) 2017 by sysmocom s.f.m.c. GmbH <info@sysmocom.de>
|
|
* (C) 2009-2012 by Holger Hans Peter Freyther <zecke@selfish.org>
|
|
* (C) 2009-2012 by On-Waves
|
|
* All Rights Reserved
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
/* Two copies of this file are kept in osmocom/mgcp/ and osmocom/mgcp_client/.
|
|
* Since both are by definition identical, use the old header exclusion ifdefs
|
|
* instead of '#pragma once' to avoid including both of these files.
|
|
* Though at the time of writing there are no such users, this allows including
|
|
* both libosmo-mgcp and libosmo-mgcp-client headers in the same file. */
|
|
#ifndef OSMO_MGCP_COMMON_H
|
|
#define OSMO_MGCP_COMMON_H
|
|
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
|
|
#include <osmocom/core/msgb.h>
|
|
#include <osmocom/core/logging.h>
|
|
|
|
#define for_each_non_empty_line(line, save) \
|
|
for (line = strtok_r(NULL, "\r\n", &save); line; \
|
|
line = strtok_r(NULL, "\r\n", &save))
|
|
|
|
enum mgcp_connection_mode {
|
|
MGCP_CONN_NONE = 0,
|
|
MGCP_CONN_RECV_ONLY = 1,
|
|
MGCP_CONN_SEND_ONLY = 2,
|
|
MGCP_CONN_RECV_SEND = MGCP_CONN_RECV_ONLY | MGCP_CONN_SEND_ONLY,
|
|
MGCP_CONN_LOOPBACK = 4 | MGCP_CONN_RECV_SEND,
|
|
};
|
|
|
|
/* Ensure that the msg->l2h is NUL terminated. */
|
|
static inline int mgcp_msg_terminate_nul(struct msgb *msg)
|
|
{
|
|
unsigned char *tail = msg->l2h + msgb_l2len(msg); /* char after l2 data */
|
|
if (tail[-1] == '\0')
|
|
/* nothing to do */;
|
|
else if (msgb_tailroom(msg) > 0)
|
|
tail[0] = '\0';
|
|
else if (tail[-1] == '\r' || tail[-1] == '\n')
|
|
tail[-1] = '\0';
|
|
else {
|
|
LOGP(DLMGCP, LOGL_ERROR, "Cannot NUL terminate MGCP message: "
|
|
"Length: %d, Buffer size: %d\n",
|
|
msgb_l2len(msg), msg->data_len);
|
|
return -ENOTSUP;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/* Maximum length of the comment field */
|
|
#define MGCP_COMMENT_MAXLEN 256
|
|
|
|
/* String length of Connection Identifiers
|
|
* (see also RFC3435 2.1.3.2 Names of Connections) */
|
|
#define MGCP_CONN_ID_LENGTH 32+1
|
|
|
|
/* String length of Endpoint Identifiers.
|
|
/ (see also RFC3435 section 3.2.1.3) */
|
|
#define MGCP_ENDPOINT_MAXLEN (255*2+1+1)
|
|
|
|
/* A prefix to denote the virtual trunk (RTP on both ends) */
|
|
#define MGCP_ENDPOINT_PREFIX_VIRTUAL_TRUNK "rtpbridge/"
|
|
|
|
/* Maximal number of payload types / codecs that can be negotiated via SDP at
|
|
* at once. */
|
|
#define MGCP_MAX_CODECS 10
|
|
|
|
#endif
|