paulmataruso/osmo-pcu
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-pcu.git synced 2025-11-02 21:23:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

ms_need_dl_tbf(): Fix state checks and document function

Browse Source 
A new state TBF_ST_WAIT_REUSE_TFI was added lately in dl_tbf_fsm, which
allows differentiating the time where the MS is listening on PACCH
after having sent last DL ACK/NACK, and time where it should already be
in idle mode.
In the former, the ms_need_dl_tbf() should return false since the MS is
still ongoing in packet-active mode (and new data incoming from SGSN
will trigger new DL TBF assignment over PACCH as needed), while in the
later we want to start a new PCH assignment.

Fixes: 40a297f3b0
Change-Id: I96f311480d036859511c6ba825ccd36bdc71190b
This commit is contained in:
Pau Espin Pedrol
2023-06-27 14:12:00 +02:00
parent 40a297f3b0
commit 28ccf7a284
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/gprs_ms.h
View File

@@ -157,11 +157,30 @@ static inline struct gprs_llc_queue *ms_llc_queue(struct GprsMs *ms)
return &ms->llc_queue;
}
/* Function used in code where a ul_tbf related event occurs and hence its state
* changes, which in turn may change the entire MS state (eg becoming reachable
* over PCH or PACCH) and the caller may want to know if it is a good time to
* assign a DL TBF (and whether we have DL data to send) */
static inline bool ms_need_dl_tbf(struct GprsMs *ms)
{
if (ms_dl_tbf(ms) != NULL &&
tbf_state((const struct gprs_rlcmac_tbf *)ms_dl_tbf(ms)) != TBF_ST_WAIT_RELEASE)
return false;
struct gprs_rlcmac_dl_tbf *dl_tbf = ms_dl_tbf(ms);
if (dl_tbf) {
switch (tbf_state(dl_tbf_as_tbf(dl_tbf))) {
case TBF_ST_NEW:
case TBF_ST_ASSIGN:
case TBF_ST_FLOW:
case TBF_ST_FINISHED:
case TBF_ST_WAIT_RELEASE:
return false; /* TBF in use, hence no need for new DL TBF */
case TBF_ST_WAIT_REUSE_TFI:
case TBF_ST_RELEASING:
/* TBF cannot be used to send further data, a new one
* may be needed, check below */
break;
default:
OSMO_ASSERT(0);
}
}
return llc_queue_size(ms_llc_queue(ms)) > 0;
}