From da2c2207b2964be213f960aa32f7fd314f3ceeb8 Mon Sep 17 00:00:00 2001
From: Neels Hofmeyr <nhofmeyr@sysmocom.de>
Date: Mon, 18 Jul 2022 13:44:42 +0200
Subject: [PATCH] drop misleading error message

call_sip_create() returns NULL only when memory allocation failed. Do
not log "No supported codec", just assert that a call was allocated,
like we usually do in such cases.

Related: SYS#5066
Change-Id: Id7fd16b92bbd10e886892d0c425cf1bc5d5429cf
---
 src/sip.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/sip.c b/src/sip.c
index ca8f4ba..61c7cbd 100644
--- a/src/sip.c
+++ b/src/sip.c
@@ -137,12 +137,7 @@ static void new_call(struct sip_agent *agent, nua_handle_t *nh,
 	}
 
 	call = call_sip_create();
-	if (!call) {
-		LOGP(DSIP, LOGL_ERROR, "No supported codec.\n");
-		nua_respond(nh, SIP_500_INTERNAL_SERVER_ERROR, TAG_END());
-		nua_handle_destroy(nh);
-		return;
-	}
+	OSMO_ASSERT(call);
 
 	/* Decode Decode the Global Call Reference (if present) */
 	if (xgcr_hdr_present) {