5 Commits

Author SHA1 Message Date
Pau Espin Pedrol
454047c586 deb/rpm packaging: Drop dependency on autoconf-archive
it is not needed since ec37263a37.

Change-Id: I729b7dc0f2971b959810a46baa8a344e8b71e4a4
2022-01-11 18:26:44 +01:00
Oliver Smith
5b7f1fd5c8 treewide: remove FSF address
Remove the paragraph about writing to the Free Software Foundation's
mailing address. The FSF has changed addresses in the past, and may do
so again. In 2021 this is not useful, let's rather have a bit less
boilerplate at the start of source files.

Change-Id: Ieb4f9b4ad5073c9b5996cb960b248c450fd5f2dd
2021-12-14 12:22:00 +01:00
Pau Espin Pedrol
8ec775714c Bump version: 0.2.0.2-ec37-dirty → 0.2.1
Change-Id: I4a2e2ff8e5f8d08fb4f8bb1f75e92ede9bb5521f
2021-11-16 18:14:21 +01:00
Oliver Smith
ec37263a37 configure: don't turn some warnings into errors
Do not turn some compiler warnings into errors by default. This part was
copied from openbsc.git 34f012 ("Turn some compiler warnings into
errors"), where it was added before --enable-werror was available.

We build with --enable-werror during development and in CI. If the code
is built with a different compiler that throws additional warnings, it
should not stop the build.

Related: OS#5289
Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31
2021-11-04 11:12:30 +01:00
Pau Espin Pedrol
44a2a85202 Use new stat item/ctr getter APIs
Generated with spatch:
"""
@@
expression E1, E2;
@@
- &E2->ctr[E1]
+ rate_ctr_group_get_ctr(E2, E1)
"""

Change-Id: I594c08b8fe0ed54a31353d8c6c911cc7293ae7c0
2021-06-04 18:07:05 +02:00
9 changed files with 30 additions and 50 deletions

View File

@@ -34,17 +34,12 @@ if test "x$PKG_CONFIG_INSTALLED" = "xno"; then
fi fi
PKG_PROG_PKG_CONFIG([0.20]) PKG_PROG_PKG_CONFIG([0.20])
dnl check for AX_CHECK_COMPILE_FLAG PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0)
m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0)
AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0)
]) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0)
PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0)
PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.4.0)
dnl checks for header files dnl checks for header files
AC_HEADER_STDC AC_HEADER_STDC
@@ -92,13 +87,6 @@ AC_COMPILE_IFELSE([AC_LANG_SOURCE([char foo;])],
CFLAGS="$saved_CFLAGS" CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY) AC_SUBST(SYMBOL_VISIBILITY)
AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"])
AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"])
AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"])
AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"])
AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"])
# Coverage build taken from WebKit's configure.in # Coverage build taken from WebKit's configure.in
AC_MSG_CHECKING([whether to enable code coverage support]) AC_MSG_CHECKING([whether to enable code coverage support])
AC_ARG_ENABLE(coverage, AC_ARG_ENABLE(coverage,

View File

@@ -25,7 +25,6 @@ Group: Hardware/Mobile
URL: https://osmocom.org/projects/osmo-smlc URL: https://osmocom.org/projects/osmo-smlc
Source: %{name}-%{version}.tar.xz Source: %{name}-%{version}.tar.xz
BuildRequires: autoconf BuildRequires: autoconf
BuildRequires: autoconf-archive
BuildRequires: automake >= 1.9 BuildRequires: automake >= 1.9
BuildRequires: libtool >= 2 BuildRequires: libtool >= 2
BuildRequires: pkgconfig >= 0.20 BuildRequires: pkgconfig >= 0.20
@@ -33,12 +32,12 @@ BuildRequires: pkgconfig >= 0.20
BuildRequires: systemd-rpm-macros BuildRequires: systemd-rpm-macros
%endif %endif
BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0
BuildRequires: pkgconfig(libosmo-sccp) >= 1.4.0 BuildRequires: pkgconfig(libosmo-sccp) >= 1.5.0
BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0
BuildRequires: pkgconfig(libosmocore) >= 1.5.0 BuildRequires: pkgconfig(libosmocore) >= 1.6.0
BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0
BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 BuildRequires: pkgconfig(libosmogsm) >= 1.6.0
BuildRequires: pkgconfig(libosmovty) >= 1.5.0 BuildRequires: pkgconfig(libosmovty) >= 1.6.0
BuildRequires: pkgconfig(talloc) BuildRequires: pkgconfig(talloc)
%{?systemd_requires} %{?systemd_requires}

10
debian/changelog vendored
View File

@@ -1,3 +1,13 @@
osmo-smlc (0.2.1) unstable; urgency=medium
[ Pau Espin Pedrol ]
* Use new stat item/ctr getter APIs
[ Oliver Smith ]
* configure: don't turn some warnings into errors
-- Pau Espin Pedrol <pespin@sysmocom.de> Tue, 16 Nov 2021 18:14:21 +0100
osmo-smlc (0.2.0) unstable; urgency=medium osmo-smlc (0.2.0) unstable; urgency=medium
[ Harald Welte ] [ Harald Welte ]

9
debian/control vendored
View File

@@ -6,16 +6,15 @@ Build-Depends: debhelper (>=9),
dh-autoreconf, dh-autoreconf,
autotools-dev, autotools-dev,
autoconf, autoconf,
autoconf-archive,
automake, automake,
libtool, libtool,
pkg-config, pkg-config,
libsctp-dev, libsctp-dev,
libtalloc-dev, libtalloc-dev,
libosmocore-dev (>= 1.5.0), libosmocore-dev (>= 1.6.0),
libosmo-sccp-dev (>= 1.4.0), libosmo-sccp-dev (>= 1.5.0),
libosmo-sigtran-dev (>= 1.4.0), libosmo-sigtran-dev (>= 1.5.0),
osmo-gsm-manuals-dev (>= 1.1.0) osmo-gsm-manuals-dev (>= 1.2.0)
Standards-Version: 3.9.8 Standards-Version: 3.9.8
Vcs-Git: git://git.osmocom.org/osmo-smlc.git Vcs-Git: git://git.osmocom.org/osmo-smlc.git
Vcs-Browser: https://git.osmocom.org/osmo-smlc/ Vcs-Browser: https://git.osmocom.org/osmo-smlc/

View File

@@ -17,10 +17,6 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details. * GNU General Public License for more details.
* *
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*
*/ */
#pragma once #pragma once

View File

@@ -17,10 +17,6 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details. * GNU General Public License for more details.
* *
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*
*/ */
#pragma once #pragma once

View File

@@ -17,10 +17,6 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details. * GNU General Public License for more details.
* *
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*
*/ */
#include <limits.h> #include <limits.h>

View File

@@ -186,14 +186,14 @@ static int sccp_lb_sap_down(struct sccp_lb_inst *sli, struct osmo_prim_hdr *oph)
{ {
int rc; int rc;
if (!sli->scu) { if (!sli->scu) {
rate_ctr_inc(&g_smlc->ctrs->ctr[SMLC_CTR_BSSMAP_LE_TX_ERR_CONN_NOT_READY]); rate_ctr_inc(rate_ctr_group_get_ctr(g_smlc->ctrs, SMLC_CTR_BSSMAP_LE_TX_ERR_CONN_NOT_READY));
return -EIO; return -EIO;
} }
rc = osmo_sccp_user_sap_down_nofree(sli->scu, oph); rc = osmo_sccp_user_sap_down_nofree(sli->scu, oph);
if (rc >= 0) if (rc >= 0)
rate_ctr_inc(&g_smlc->ctrs->ctr[SMLC_CTR_BSSMAP_LE_TX_SUCCESS]); rate_ctr_inc(rate_ctr_group_get_ctr(g_smlc->ctrs, SMLC_CTR_BSSMAP_LE_TX_SUCCESS));
else else
rate_ctr_inc(&g_smlc->ctrs->ctr[SMLC_CTR_BSSMAP_LE_TX_ERR_SEND]); rate_ctr_inc(rate_ctr_group_get_ctr(g_smlc->ctrs, SMLC_CTR_BSSMAP_LE_TX_ERR_SEND));
return rc; return rc;
} }

View File

@@ -17,10 +17,6 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details. * GNU General Public License for more details.
* *
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*
*/ */
#include <osmocom/smlc/smlc_data.h> #include <osmocom/smlc/smlc_data.h>
@@ -96,7 +92,7 @@ static int smlc_loc_req_start(struct lb_conn *lb_conn, const struct bssmap_le_pe
{ {
struct smlc_loc_req *smlc_loc_req; struct smlc_loc_req *smlc_loc_req;
rate_ctr_inc(&g_smlc->ctrs->ctr[SMLC_CTR_BSSMAP_LE_RX_DT1_PERFORM_LOCATION_REQUEST]); rate_ctr_inc(rate_ctr_group_get_ctr(g_smlc->ctrs, SMLC_CTR_BSSMAP_LE_RX_DT1_PERFORM_LOCATION_REQUEST));
if (lb_conn->smlc_loc_req) { if (lb_conn->smlc_loc_req) {
/* Another request is already pending. If we send Perform Location Abort, the peer doesn't know which /* Another request is already pending. If we send Perform Location Abort, the peer doesn't know which