8 Commits

Author SHA1 Message Date
Gerrit User 1000074
36e3d92e9a Update patch set 2
Change has been successfully merged

Patch-set: 2
Status: merged
Tag: autogenerated:gerrit:merged
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: SUBM=+1, 5ec0841344167e3e57cd843a85437b13ec02c658
Submission-id: 40679
Submitted-with: OK
Submitted-with: Rule-Name: gerrit~DefaultSubmitRule
Submitted-with: OK: Code-Review: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Submitted-with: OK: Verified: Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Change was submitted"}
2025-07-15 10:53:13 +00:00
Gerrit User 1000074
c515850bf7 Update patch set 2
Patch Set 2: Code-Review+2

Patch-set: 2
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2, 9ccdf2224dd582ad515e502d8ede938aebe6004e
2025-07-15 10:53:10 +00:00
Gerrit User 1000002
b22b4eed65 Update patch set 2
Patch Set 2: Verified+1

4 passed:
* [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-smlc-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/55/consoleFull
* [debian:10] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/16451/consoleFull
* [debian:12] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/16452/consoleFull
* [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/23710/consoleFull

Build Successful

Patch-set: 2
Tag: jenkins
Reviewer: Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>
Label: Verified=+1, 23f36a0b4765fb0989a7990b3e3935dc98e89ce3
2025-07-15 10:17:31 +00:00
Gerrit User 1000002
d6b0ab8547 Update patch set 2
Patch Set 2:

Build Started
https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-smlc/53/consoleFull

Patch-set: 2
Tag: jenkins
2025-07-15 10:16:03 +00:00
Gerrit User 1000074
89a8925da7 Create patch set 2
Uploaded patch set 2.

Outdated Votes:
* Code-Review+1 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN")
* Verified+1 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE")


Patch-set: 2
Subject: vty: Create smlc_vty.c
Commit: 28748a57bb
Tag: autogenerated:gerrit:newPatchSet
Groups: 28748a57bb
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}
2025-07-15 10:15:31 +00:00
Gerrit User 1000074
4d13c24400 Update patch set 1
Patch Set 1:

(2 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
2025-07-15 10:15:25 +00:00
Gerrit User 1000010
ff2b5e4cf7 Update patch set 1
Patch Set 1:

(2 comments)

Patch-set: 1
CC: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
2025-07-15 10:00:44 +00:00
Gerrit User 1000004
bbfa8eefd4 Update patch set 1
Patch Set 1: Code-Review+1

Patch-set: 1
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, e935bbcf45b0b8a16d17e02192871fd7421336cd
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
2025-07-15 08:26:32 +00:00
2 changed files with 102 additions and 0 deletions

View File

@@ -0,0 +1,4 @@
{
"comments": [],
"submitRequirementResults": []
}

View File

@@ -0,0 +1,98 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "c3af3688_b7ad45c7",
"filename": "src/osmo-smlc/smlc_main.c",
"patchSetId": 1
},
"lineNbr": 22,
"author": {
"id": 1000010
},
"writtenOn": "2025-07-15T10:00:44Z",
"side": 1,
"message": "not needed anymore?",
"range": {
"startLine": 22,
"startChar": 10,
"endLine": 22,
"endChar": 36
},
"revId": "67d2b10bb1d6dd9be9dc58ad6b5df4d48061b018",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "58880c03_d036d103",
"filename": "src/osmo-smlc/smlc_main.c",
"patchSetId": 1
},
"lineNbr": 22,
"author": {
"id": 1000074
},
"writtenOn": "2025-07-15T10:15:25Z",
"side": 1,
"message": "Done",
"parentUuid": "c3af3688_b7ad45c7",
"range": {
"startLine": 22,
"startChar": 10,
"endLine": 22,
"endChar": 36
},
"revId": "67d2b10bb1d6dd9be9dc58ad6b5df4d48061b018",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "6f0f7f52_2e2f9340",
"filename": "src/osmo-smlc/smlc_main.c",
"patchSetId": 1
},
"lineNbr": 34,
"author": {
"id": 1000010
},
"writtenOn": "2025-07-15T10:00:44Z",
"side": 1,
"message": "not needed anymore?",
"range": {
"startLine": 32,
"startChar": 0,
"endLine": 34,
"endChar": 2
},
"revId": "67d2b10bb1d6dd9be9dc58ad6b5df4d48061b018",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "8e47064a_90acc922",
"filename": "src/osmo-smlc/smlc_main.c",
"patchSetId": 1
},
"lineNbr": 34,
"author": {
"id": 1000074
},
"writtenOn": "2025-07-15T10:15:25Z",
"side": 1,
"message": "Done",
"parentUuid": "6f0f7f52_2e2f9340",
"range": {
"startLine": 32,
"startChar": 0,
"endLine": 34,
"endChar": 2
},
"revId": "67d2b10bb1d6dd9be9dc58ad6b5df4d48061b018",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}