paulmataruso/osmo-trx
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-trx.git synced 2025-10-30 19:53:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

ms: fix a few coverity complaints related to initialization

Browse Source 
Change-Id: I203f4da7a4418fc5053d26901bec649d04fad096
This commit is contained in:
Eric
2023-08-17 16:27:33 +02:00
parent d372eb2f0b
commit 58294fde4b
3 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Transceiver52M/ms/ms.h
View File

@@ -50,7 +50,7 @@ const unsigned int SCH_LEN_SPS = (ONE_TS_BURST_LEN * 8 /*ts*/ * 12 /*frames*/);
template <typename T> template <typename T>
void clamp_array(T *start2, unsigned int len, T max) void clamp_array(T *start2, unsigned int len, T max)
{ {
for (int i = 0; i < len; i++) { for (unsigned int i = 0; i < len; i++) {
const T t1 = start2[i] < -max ? -max : start2[i]; const T t1 = start2[i] < -max ? -max : start2[i];
const T t2 = t1 > max ? max : t1; const T t2 = t1 > max ? max : t1;
start2[i] = t2; start2[i] = t2;
@@ -263,7 +263,6 @@ struct ms_trx : public BASET {
std::thread lower_rx_task; std::thread lower_rx_task;
std::thread lower_tx_task; std::thread lower_tx_task;
std::thread *calcrval_task;
// provides bursts to upper rx thread // provides bursts to upper rx thread
rx_queue_t rxqueue; rx_queue_t rxqueue;
@@ -300,10 +299,12 @@ struct ms_trx : public BASET {
void maybe_update_gain(one_burst &brst); void maybe_update_gain(one_burst &brst);
ms_trx() ms_trx()
: timing_advance(0), do_auto_gain(false), rxqueue(), first_sch_buf(new blade_sample_type[SCH_LEN_SPS]), : mTSC(0), mBSIC(0), timing_advance(0), do_auto_gain(false), rxqueue(),
burst_copy_buffer(new blade_sample_type[ONE_TS_BURST_LEN]), rcv_done{ false }, first_sch_buf(new blade_sample_type[SCH_LEN_SPS]),
sch_thread_done{ false }, hw_cpus(std::thread::hardware_concurrency()), burst_copy_buffer(new blade_sample_type[ONE_TS_BURST_LEN]), first_sch_buf_rcv_ts(0),
hw_target(hw_cpus > 4 ? sched_params::target::ODROID : sched_params::target::PI4) rcv_done{ false }, sch_thread_done{ false }, hw_cpus(std::thread::hardware_concurrency()),
hw_target(hw_cpus > 4 ? sched_params::target::ODROID : sched_params::target::PI4),
upper_is_ready(false)
{ {
std::cerr << "scheduling for: " << (hw_cpus > 4 ? "odroid" : "pi4") << std::endl; std::cerr << "scheduling for: " << (hw_cpus > 4 ? "odroid" : "pi4") << std::endl;
set_name_aff_sched(worker_thread.get_handle(), sched_params::thread_names::SCH_SEARCH); set_name_aff_sched(worker_thread.get_handle(), sched_params::thread_names::SCH_SEARCH);

2
Transceiver52M/ms/ms_upper.h
View File

@@ -44,5 +44,5 @@ class upper_trx : public ms_trx {
void driveReceiveFIFO(); void driveReceiveFIFO();
void driveTx(); void driveTx();
upper_trx(){}; upper_trx() : mOn(false){};
}; };

2
Transceiver52M/ms/threadpool.h
View File

@@ -45,7 +45,7 @@ struct single_thread_pool {
return; return;
} }
single_thread_pool() : worker_thread(std::thread([this] { thread_loop(); })) single_thread_pool() : stop_flag(false), is_ready(false), worker_thread(std::thread([this] { thread_loop(); }))
{ {
} }
~single_thread_pool() ~single_thread_pool()