mirror of
https://gitea.osmocom.org/cellular-infrastructure/osmo-trx.git
synced 2025-11-04 06:03:17 +00:00
86be40b4eb
pthread_cancel is implemented in c++ using exception handlers. In destructor of Log object, the log function is called which will eventually call fputs() to write to a file. Since that function is considered a cancelation point, if pthread_cancel has been called the exception handler will start unstacking frames and calling destructors in the process. At some point this will cause a runtime exception in c++ which will call std::terminate() to abort the process. The solution is thus to avoid starting the cancellation process inside the destructor. This behavior was spotted while calling the destructor of Transceiver object in forthcoming patches. See a more detailed example here: https://skaark.wordpress.com/2010/08/26/pthread_cancel-considered-harmful/ Change-Id: I71ca90f3fbc73df58b878a03361f7b7831d838b4
65 lines
1.8 KiB
C++
65 lines
1.8 KiB
C++
/*
|
|
* Copyright (C) 2018 sysmocom - s.f.m.c. GmbH
|
|
*
|
|
*
|
|
* This software is distributed under the terms of the GNU Affero Public License.
|
|
* See the COPYING file in the main directory for details.
|
|
*
|
|
* This use of this software may be subject to additional restrictions.
|
|
* See the LEGAL file in the main directory for details.
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU Affero General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU Affero General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Affero General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
#include <string.h>
|
|
#include <cstdio>
|
|
#include <fstream>
|
|
#include <string>
|
|
#include <stdarg.h>
|
|
#include <sys/time.h> // For gettimeofday
|
|
|
|
#include "Logger.h"
|
|
#include "Threads.h" // pat added
|
|
|
|
using namespace std;
|
|
|
|
Mutex gLogToLock;
|
|
|
|
std::ostream& operator<<(std::ostream& os, std::ostringstream& ss)
|
|
{
|
|
return os << ss.str();
|
|
}
|
|
|
|
Log::~Log()
|
|
{
|
|
int old_state;
|
|
pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_state);
|
|
int mlen = mStream.str().size();
|
|
int neednl = (mlen==0 || mStream.str()[mlen-1] != '\n');
|
|
const char *fmt = neednl ? "%s\n" : "%s";
|
|
ScopedLock lock(gLogToLock);
|
|
// The COUT() macro prevents messages from stomping each other but adds uninteresting thread numbers,
|
|
// so just use std::cout.
|
|
LOGPSRC(mCategory, mPriority, filename, line, fmt, mStream.str().c_str());
|
|
pthread_setcancelstate(old_state, NULL);
|
|
}
|
|
|
|
ostringstream& Log::get()
|
|
{
|
|
return mStream;
|
|
}
|
|
|
|
// vim: ts=4 sw=4
|