fix(frontend): eliminate duplicate API calls during log in/out

frontend/src/contexts/AuthContext.jsx

@@ -95,14 +95,6 @@ export const AuthProvider = ({ children }) => {
 		}
 	}, [fetchPermissions]);
 
-	// Refresh permissions when user logs in (no automatic refresh)
-	useEffect(() => {
-		if (token && user) {
-			// Only refresh permissions once when user logs in
-			refreshPermissions();
-		}
-	}, [token, user, refreshPermissions]);
-
 	const login = async (username, password) => {
 		try {
 			const response = await fetch("/api/v1/auth/login", {
@@ -116,6 +108,12 @@ export const AuthProvider = ({ children }) => {
 			const data = await response.json();
 
 			if (response.ok) {
+				// Check if TFA is required
+				if (data.requiresTfa) {
+					return { success: true, requiresTfa: true };
+				}
+
+				// Regular successful login
 				setToken(data.token);
 				setUser(data.user);
 				localStorage.setItem("token", data.token);

frontend/src/pages/Login.jsx

@@ -67,24 +67,18 @@ const Login = () => {
 		setError("");
 
 		try {
-			const response = await authAPI.login(
+			// Use the AuthContext login function which handles everything
-				formData.username,
+			const result = await login(formData.username, formData.password);
-				formData.password,
-			);
 
-			if (response.data.requiresTfa) {
+			if (result.requiresTfa) {
 				setRequiresTfa(true);
 				setTfaUsername(formData.username);
 				setError("");
-			} else {
+			} else if (result.success) {
-				// Regular login successful
-				const result = await login(formData.username, formData.password);
-				if (result.success) {
 				navigate("/");
 			} else {
 				setError(result.error || "Login failed");
 			}
-			}
 		} catch (err) {
 			setError(err.response?.data?.error || "Login failed");
 		} finally {