From de449c547fa004908f1e4ad1e6e825a3505e2fb6 Mon Sep 17 00:00:00 2001 From: Muhammad Ibrahim Date: Wed, 22 Oct 2025 15:22:14 +0100 Subject: [PATCH] Fixed some ratelimits that were hardcoded and ammended docker compose to take into consideration rate limits --- backend/src/server.js | 6 +++--- docker/docker-compose.dev.yml | 7 +++++++ docker/docker-compose.yml | 7 +++++++ 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/backend/src/server.js b/backend/src/server.js index 27414d7..d13d3de 100644 --- a/backend/src/server.js +++ b/backend/src/server.js @@ -295,7 +295,7 @@ app.disable("x-powered-by"); // Rate limiting with monitoring const limiter = rateLimit({ windowMs: parseInt(process.env.RATE_LIMIT_WINDOW_MS, 10) || 15 * 60 * 1000, - max: parseInt(process.env.RATE_LIMIT_MAX, 10) || 100, + max: parseInt(process.env.RATE_LIMIT_MAX, 10) || 5000, message: { error: "Too many requests from this IP, please try again later.", retryAfter: Math.ceil( @@ -424,7 +424,7 @@ const apiVersion = process.env.API_VERSION || "v1"; const authLimiter = rateLimit({ windowMs: parseInt(process.env.AUTH_RATE_LIMIT_WINDOW_MS, 10) || 10 * 60 * 1000, - max: parseInt(process.env.AUTH_RATE_LIMIT_MAX, 10) || 20, + max: parseInt(process.env.AUTH_RATE_LIMIT_MAX, 10) || 500, message: { error: "Too many authentication requests, please try again later.", retryAfter: Math.ceil( @@ -438,7 +438,7 @@ const authLimiter = rateLimit({ }); const agentLimiter = rateLimit({ windowMs: parseInt(process.env.AGENT_RATE_LIMIT_WINDOW_MS, 10) || 60 * 1000, - max: parseInt(process.env.AGENT_RATE_LIMIT_MAX, 10) || 120, + max: parseInt(process.env.AGENT_RATE_LIMIT_MAX, 10) || 1000, message: { error: "Too many agent requests, please try again later.", retryAfter: Math.ceil( diff --git a/docker/docker-compose.dev.yml b/docker/docker-compose.dev.yml index 47e8f03..1568cc1 100644 --- a/docker/docker-compose.dev.yml +++ b/docker/docker-compose.dev.yml @@ -50,6 +50,13 @@ services: SERVER_HOST: localhost SERVER_PORT: 3000 CORS_ORIGIN: http://localhost:3000 + # Rate Limiting (times in milliseconds) + RATE_LIMIT_WINDOW_MS: 900000 + RATE_LIMIT_MAX: 5000 + AUTH_RATE_LIMIT_WINDOW_MS: 600000 + AUTH_RATE_LIMIT_MAX: 500 + AGENT_RATE_LIMIT_WINDOW_MS: 60000 + AGENT_RATE_LIMIT_MAX: 1000 # Redis Configuration REDIS_HOST: redis REDIS_PORT: 6379 diff --git a/docker/docker-compose.yml b/docker/docker-compose.yml index cac66de..29f08e9 100644 --- a/docker/docker-compose.yml +++ b/docker/docker-compose.yml @@ -56,6 +56,13 @@ services: SERVER_HOST: localhost SERVER_PORT: 3000 CORS_ORIGIN: http://localhost:3000 + # Rate Limiting (times in milliseconds) + RATE_LIMIT_WINDOW_MS: 900000 + RATE_LIMIT_MAX: 5000 + AUTH_RATE_LIMIT_WINDOW_MS: 600000 + AUTH_RATE_LIMIT_MAX: 500 + AGENT_RATE_LIMIT_WINDOW_MS: 60000 + AGENT_RATE_LIMIT_MAX: 1000 # Redis Configuration REDIS_HOST: redis REDIS_PORT: 6379