Merge pull request #10 from lantean-code/feature/bugfixes

- Fixed an issue where the tag wasn't being correctly applied to the filter in qBittorrent 5.1+ (#9)
- Fixed an issue where the category wasn't being applied to the filter correctly (#9)
- Fixed invalid ValueChanged for "Default Torrent Management Mode"
- Fixed a crash where TimeSpan.FromSeconds was crashing
- Fixed an invalid icon to appear when Paused/Stopped

Lantean.QBTMud/Components/Options/DownloadsOptions.razor

@@ -62,7 +62,7 @@
     <MudCardContent Class="pt-0">
         <MudGrid>
             <MudItem xs="12">
-                <MudSelect T="bool" Label="Default Torrent Management Mode" Value="AutoTmmEnabled" ValueChanged="AutoDeleteModeChanged" Variant="Variant.Outlined">
+                <MudSelect T="bool" Label="Default Torrent Management Mode" Value="AutoTmmEnabled" ValueChanged="AutoTmmEnabledChanged" Variant="Variant.Outlined">
                     <MudSelectItem Value="false">Manual</MudSelectItem>
                     <MudSelectItem Value="true">Automatic</MudSelectItem>
                 </MudSelect>

Lantean.QBTMud/Helpers/DisplayHelpers.cs

@@ -19,28 +19,28 @@ namespace Lantean.QBTMud.Helpers
         {
             if (seconds is null)
             {
-                return "";
+                return string.Empty;
             }
 
-            if (seconds == 8640000)
+            const long InfiniteEtaSentinelSeconds = 8_640_000; // ~100 days, used by qBittorrent for "infinite" ETA.
+            var value = seconds.Value;
+
+            if (value >= long.MaxValue || value >= TimeSpan.MaxValue.TotalSeconds || value == InfiniteEtaSentinelSeconds)
             {
                 return "∞";
             }
 
-            if (seconds < 60)
+            if (value <= 0)
             {
                 return "< 1m";
             }
 
-            TimeSpan time;
+            var time = TimeSpan.FromSeconds(value);
-            try
+            if (time.TotalMinutes < 1)
             {
-                time = TimeSpan.FromSeconds(seconds.Value);
+                return "< 1m";
-            }
-            catch
-            {
-                return "∞";
             }
+
             var sb = new StringBuilder();
             if (prefix is not null)
             {
@@ -83,6 +83,7 @@ namespace Lantean.QBTMud.Helpers
             return sb.ToString();
         }
 
+
         /// <summary>
         /// Formats a file size in bytes into an appropriate unit based on the size.
         /// </summary>

Lantean.QBTMud/Helpers/FilterHelper.cs

@@ -119,34 +119,34 @@ namespace Lantean.QBTMud.Helpers
             switch (category)
             {
                 case CATEGORY_ALL:
-                    break;
+                    return true;
 
                 case CATEGORY_UNCATEGORIZED:
                     if (!string.IsNullOrEmpty(torrent.Category))
                     {
                         return false;
                     }
-                    break;
 
+                    return true;
                 default:
+                    if (string.IsNullOrEmpty(torrent.Category))
+                    {
+                        return false;
+                    }
+
                     if (!useSubcategories)
                     {
-                        if (torrent.Category != category)
+                        return string.Equals(torrent.Category, category, StringComparison.Ordinal);
-                        {
-                            return false;
-                        }
-                        else
-                        {
-                            if (!torrent.Category.StartsWith(category))
-                            {
-                                return false;
-                            }
-                        }
                     }
-                    break;
-            }
 
-            return true;
+                    if (string.Equals(torrent.Category, category, StringComparison.Ordinal))
+                    {
+                        return true;
+                    }
+
+                    var prefix = string.Concat(category, "/");
+                    return torrent.Category.StartsWith(prefix, StringComparison.Ordinal);
+            }
         }
 
         public static bool FilterTag(Torrent torrent, string tag)
@@ -207,7 +207,7 @@ namespace Lantean.QBTMud.Helpers
                     break;
 
                 case Status.Paused:
-                    if (!state.Contains("paused") || !state.Contains("stopped"))
+                    if (!state.Contains("paused") && !state.Contains("stopped"))
                     {
                         return false;
                     }

Lantean.QBTMud/Services/DataManager.cs

@@ -39,12 +39,19 @@ namespace Lantean.QBTMud.Services
                 }
             }
 
-            var tags = new List<string>(mainData.Tags?.Count ?? 0);
+            var tags = new List<string>();
             if (mainData.Tags is not null)
             {
+                var seenTags = new HashSet<string>(StringComparer.Ordinal);
                 foreach (var tag in mainData.Tags)
                 {
-                    tags.Add(tag);
+                    var normalizedTag = NormalizeTag(tag);
+                    if (string.IsNullOrEmpty(normalizedTag) || !seenTags.Add(normalizedTag))
+                    {
+                        continue;
+                    }
+
+                    tags.Add(normalizedTag);
                 }
             }
 
@@ -157,8 +164,14 @@ namespace Lantean.QBTMud.Services
             {
                 foreach (var tag in mainData.TagsRemoved)
                 {
-                    torrentList.Tags.Remove(tag);
+                    var normalizedTag = NormalizeTag(tag);
-                    torrentList.TagState.Remove(tag);
+                    if (string.IsNullOrEmpty(normalizedTag))
+                    {
+                        continue;
+                    }
+
+                    torrentList.Tags.Remove(normalizedTag);
+                    torrentList.TagState.Remove(normalizedTag);
                 }
             }
 
@@ -200,7 +213,18 @@ namespace Lantean.QBTMud.Services
             {
                 foreach (var tag in mainData.Tags)
                 {
-                    torrentList.Tags.Add(tag);
+                    var normalizedTag = NormalizeTag(tag);
+                    if (string.IsNullOrEmpty(normalizedTag))
+                    {
+                        continue;
+                    }
+
+                    torrentList.Tags.Add(normalizedTag);
+                    var matchingHashes = torrentList.Torrents
+                        .Where(pair => FilterHelper.FilterTag(pair.Value, normalizedTag))
+                        .Select(pair => pair.Key)
+                        .ToHashSet();
+                    torrentList.TagState[normalizedTag] = matchingHashes;
                 }
             }
 
@@ -508,6 +532,12 @@ namespace Lantean.QBTMud.Services
 
         public Torrent CreateTorrent(string hash, QBitTorrentClient.Models.Torrent torrent)
         {
+            var normalizedTags = torrent.Tags?
+                .Select(NormalizeTag)
+                .Where(static tag => !string.IsNullOrEmpty(tag))
+                .ToList()
+                ?? new List<string>();
+
             return new Torrent(
                 hash,
                 torrent.AddedOn.GetValueOrDefault(),
@@ -548,7 +578,7 @@ namespace Lantean.QBTMud.Services
                 torrent.Size.GetValueOrDefault(),
                 torrent.State!,
                 torrent.SuperSeeding.GetValueOrDefault(),
-                torrent.Tags!,
+                normalizedTags,
                 torrent.TimeActive.GetValueOrDefault(),
                 torrent.TotalSize.GetValueOrDefault(),
                 torrent.Tracker!,
@@ -561,6 +591,19 @@ namespace Lantean.QBTMud.Services
                 torrent.MaxInactiveSeedingTime.GetValueOrDefault());
         }
 
+        private static string NormalizeTag(string? tag)
+        {
+            if (string.IsNullOrEmpty(tag))
+            {
+                return string.Empty;
+            }
+
+            var separatorIndex = tag.IndexOf('\t');
+            var normalized = (separatorIndex >= 0) ? tag[..separatorIndex] : tag;
+
+            return normalized.Trim();
+        }
+
         private static void UpdateCategory(Category existingCategory, QBitTorrentClient.Models.Category category)
         {
             existingCategory.SavePath = category.SavePath ?? existingCategory.SavePath;
@@ -609,7 +652,14 @@ namespace Lantean.QBTMud.Services
             if (torrent.Tags is not null)
             {
                 existingTorrent.Tags.Clear();
-                existingTorrent.Tags.AddRange(torrent.Tags);
+                foreach (var tag in torrent.Tags)
+                {
+                    var normalizedTag = NormalizeTag(tag);
+                    if (!string.IsNullOrEmpty(normalizedTag))
+                    {
+                        existingTorrent.Tags.Add(normalizedTag);
+                    }
+                }
             }
             existingTorrent.TimeActive = torrent.TimeActive ?? existingTorrent.TimeActive;
             existingTorrent.TotalSize = torrent.TotalSize ?? existingTorrent.TotalSize;