6 Commits

Author SHA1 Message Date
ahjephson
300e81345c Fix status update performance 2025-10-20 11:03:43 +01:00
ahjephson
4824037ba7 Fix connection icon 2025-10-20 10:04:50 +01:00
ahjephson
1f9b631a36 Merge bugfixes in 2025-10-20 09:52:55 +01:00
ahjephson
d4ac79af00 Merge pull request #10 from lantean-code/feature/bugfixes
- Fixed an issue where the tag wasn't being correctly applied to the filter in qBittorrent 5.1+ (#9)
- Fixed an issue where the category wasn't being applied to the filter correctly (#9)
- Fixed invalid ValueChanged for "Default Torrent Management Mode"
- Fixed a crash where TimeSpan.FromSeconds was crashing
- Fixed an invalid icon to appear when Paused/Stopped
2025-10-18 16:18:10 +01:00
ahjephson
7370d73c59 Fix minor display issues 2025-10-18 16:01:53 +01:00
ahjephson
8796cc0f24 Fix #9 and bug related to invalid TimeSpan in duration 2025-10-18 15:37:04 +01:00
6 changed files with 394 additions and 151 deletions

View File

@@ -62,7 +62,7 @@
<MudCardContent Class="pt-0">
<MudGrid>
<MudItem xs="12">
<MudSelect T="bool" Label="Default Torrent Management Mode" Value="AutoTmmEnabled" ValueChanged="AutoDeleteModeChanged" Variant="Variant.Outlined">
<MudSelect T="bool" Label="Default Torrent Management Mode" Value="AutoTmmEnabled" ValueChanged="AutoTmmEnabledChanged" Variant="Variant.Outlined">
<MudSelectItem Value="false">Manual</MudSelectItem>
<MudSelectItem Value="true">Automatic</MudSelectItem>
</MudSelect>

View File

@@ -19,28 +19,28 @@ namespace Lantean.QBTMud.Helpers
{
if (seconds is null)
{
return "";
return string.Empty;
}
if (seconds == 8640000)
const long InfiniteEtaSentinelSeconds = 8_640_000; // ~100 days, used by qBittorrent for "infinite" ETA.
var value = seconds.Value;
if (value >= long.MaxValue || value >= TimeSpan.MaxValue.TotalSeconds || value == InfiniteEtaSentinelSeconds)
{
return "∞";
}
if (seconds < 60)
if (value <= 0)
{
return "< 1m";
}
TimeSpan time;
try
var time = TimeSpan.FromSeconds(value);
if (time.TotalMinutes < 1)
{
time = TimeSpan.FromSeconds(seconds.Value);
}
catch
{
return "∞";
return "< 1m";
}
var sb = new StringBuilder();
if (prefix is not null)
{
@@ -83,6 +83,7 @@ namespace Lantean.QBTMud.Helpers
return sb.ToString();
}
/// <summary>
/// Formats a file size in bytes into an appropriate unit based on the size.
/// </summary>

View File

@@ -119,34 +119,34 @@ namespace Lantean.QBTMud.Helpers
switch (category)
{
case CATEGORY_ALL:
break;
return true;
case CATEGORY_UNCATEGORIZED:
if (!string.IsNullOrEmpty(torrent.Category))
{
return false;
}
break;
return true;
default:
if (string.IsNullOrEmpty(torrent.Category))
{
return false;
}
if (!useSubcategories)
{
if (torrent.Category != category)
{
return false;
}
else
{
if (!torrent.Category.StartsWith(category))
{
return false;
}
}
return string.Equals(torrent.Category, category, StringComparison.Ordinal);
}
break;
}
return true;
if (string.Equals(torrent.Category, category, StringComparison.Ordinal))
{
return true;
}
var prefix = string.Concat(category, "/");
return torrent.Category.StartsWith(prefix, StringComparison.Ordinal);
}
}
public static bool FilterTag(Torrent torrent, string tag)
@@ -207,7 +207,7 @@ namespace Lantean.QBTMud.Helpers
break;
case Status.Paused:
if (!state.Contains("paused") || !state.Contains("stopped"))
if (!state.Contains("paused") && !state.Contains("stopped"))
{
return false;
}

View File

@@ -50,7 +50,7 @@
@{
var (icon, colour) = GetConnectionIcon(MainData?.ServerState.ConnectionStatus);
}
<MudIcon Class="mx-1 mb-1" Icon="@icon" Color="@colour" Title="MainData?.ServerState.ConnectionStatus" />
<MudIcon Class="mx-1 mb-1" Icon="@icon" Color="@colour" Title="@MainData?.ServerState.ConnectionStatus" />
<MudDivider Vertical="true" Class="" />
<MudIcon Class="mx-1 mb-1" Icon="@Icons.Material.Outlined.Speed" Color="@((MainData?.ServerState.UseAltSpeedLimits ?? false) ? Color.Error : Color.Success)" />
<MudDivider Vertical="true" Class="" />

View File

@@ -195,12 +195,12 @@ namespace Lantean.QBTMud.Layout
protected static (string, Color) GetConnectionIcon(string? status)
{
if (status is null)
return status switch
{
return (Icons.Material.Outlined.SignalWifiOff, Color.Warning);
}
return (Icons.Material.Outlined.SignalWifi4Bar, Color.Success);
"firewalled" => (Icons.Material.Outlined.SignalWifiStatusbarConnectedNoInternet4, Color.Warning),
"connected" => (Icons.Material.Outlined.SignalWifi4Bar, Color.Success),
_ => (Icons.Material.Outlined.SignalWifiOff, Color.Error),
};
}
private void OnCategoryChanged(string category)

View File

@@ -40,12 +40,19 @@ namespace Lantean.QBTMud.Services
}
}
var tags = new List<string>(mainData.Tags?.Count ?? 0);
var tags = new List<string>();
if (mainData.Tags is not null)
{
var seenTags = new HashSet<string>(StringComparer.Ordinal);
foreach (var tag in mainData.Tags)
{
tags.Add(tag);
var normalizedTag = NormalizeTag(tag);
if (string.IsNullOrEmpty(normalizedTag) || !seenTags.Add(normalizedTag))
{
continue;
}
tags.Add(normalizedTag);
}
}
@@ -168,15 +175,17 @@ namespace Lantean.QBTMud.Services
{
foreach (var tag in mainData.TagsRemoved)
{
if (torrentList.Tags.Remove(tag))
var normalizedTag = NormalizeTag(tag);
if (string.IsNullOrEmpty(normalizedTag))
{
dataChanged = true;
filterChanged = true;
continue;
}
if (torrentList.TagState.Remove(tag))
if (torrentList.TagState.Remove(normalizedTag))
{
filterChanged = true;
}
torrentList.TagState.Remove(normalizedTag);
}
}
@@ -231,11 +240,22 @@ namespace Lantean.QBTMud.Services
{
foreach (var tag in mainData.Tags)
{
if (torrentList.Tags.Add(tag))
var normalizedTag = NormalizeTag(tag);
if (string.IsNullOrEmpty(normalizedTag))
{
continue;
}
if (torrentList.Tags.Add(normalizedTag))
{
dataChanged = true;
filterChanged = true;
}
var matchingHashes = torrentList.Torrents
.Where(pair => FilterHelper.FilterTag(pair.Value, normalizedTag))
.Select(pair => pair.Key)
.ToHashSet();
torrentList.TagState[normalizedTag] = matchingHashes;
}
}
@@ -271,10 +291,11 @@ namespace Lantean.QBTMud.Services
}
else
{
var previousSnapshot = CreateSnapshot(existingTorrent);
var updateResult = UpdateTorrent(existingTorrent, torrent);
if (updateResult.FilterChanged)
{
UpdateTorrentStates(torrentList, hash);
UpdateTorrentStates(torrentList, hash, previousSnapshot, existingTorrent);
filterChanged = true;
}
if (updateResult.DataChanged)
@@ -298,50 +319,32 @@ namespace Lantean.QBTMud.Services
private static void AddTorrentToStates(MainData torrentList, string hash, int version)
{
var torrent = torrentList.Torrents[hash];
if (!torrentList.Torrents.TryGetValue(hash, out var torrent))
{
return;
}
torrentList.TagState[FilterHelper.TAG_ALL].Add(hash);
torrentList.TagState[FilterHelper.TAG_UNTAGGED].AddIfTrue(hash, FilterHelper.FilterTag(torrent, FilterHelper.TAG_UNTAGGED));
foreach (var tag in torrentList.Tags)
{
if (!torrentList.TagState.TryGetValue(tag, out HashSet<string>? value))
{
value = [];
torrentList.TagState.Add(tag, value);
}
value.AddIfTrue(hash, FilterHelper.FilterTag(torrent, tag));
}
UpdateTagStateForAddition(torrentList, torrent, hash);
torrentList.CategoriesState[FilterHelper.CATEGORY_ALL].Add(hash);
torrentList.CategoriesState[FilterHelper.CATEGORY_UNCATEGORIZED].AddIfTrue(hash, FilterHelper.FilterCategory(torrent, FilterHelper.CATEGORY_UNCATEGORIZED, torrentList.ServerState.UseSubcategories));
foreach (var category in torrentList.Categories.Keys)
{
if (!torrentList.CategoriesState.TryGetValue(category, out HashSet<string>? value))
{
value = [];
torrentList.CategoriesState.Add(category, value);
}
value.AddIfTrue(hash, FilterHelper.FilterCategory(torrent, category, torrentList.ServerState.UseSubcategories));
}
UpdateCategoryState(torrentList, torrent, hash, previousCategory: null);
foreach (var status in GetStatuses(version))
{
torrentList.StatusState[status.ToString()].AddIfTrue(hash, FilterHelper.FilterStatus(torrent, status));
if (!torrentList.StatusState.TryGetValue(status.ToString(), out var statusSet))
{
continue;
}
if (FilterHelper.FilterStatus(torrent, status))
{
statusSet.Add(hash);
}
}
torrentList.TrackersState[FilterHelper.TRACKER_ALL].Add(hash);
torrentList.TrackersState[FilterHelper.TRACKER_TRACKERLESS].AddIfTrue(hash, FilterHelper.FilterTracker(torrent, FilterHelper.TRACKER_TRACKERLESS));
foreach (var tracker in torrentList.Trackers.Keys)
{
if (!torrentList.TrackersState.TryGetValue(tracker, out HashSet<string>? value))
{
value = [];
torrentList.TrackersState.Add(tracker, value);
}
value.AddIfTrue(hash, FilterHelper.FilterTracker(torrent, tracker));
}
UpdateTrackerState(torrentList, torrent, hash, previousTracker: null);
}
private static Status[] GetStatuses(int version)
@@ -363,77 +366,28 @@ namespace Lantean.QBTMud.Services
return _statusArray;
}
private static void UpdateTorrentStates(MainData torrentList, string hash)
private static void UpdateTorrentStates(MainData torrentList, string hash, TorrentSnapshot previousSnapshot, Torrent updatedTorrent)
{
var torrent = torrentList.Torrents[hash];
torrentList.TagState[FilterHelper.TAG_UNTAGGED].AddIfTrueOrRemove(hash, FilterHelper.FilterTag(torrent, FilterHelper.TAG_UNTAGGED));
foreach (var tag in torrentList.Tags)
{
if (!torrentList.TagState.TryGetValue(tag, out HashSet<string>? value))
{
value = [];
torrentList.TagState.Add(tag, value);
}
value.AddIfTrueOrRemove(hash, FilterHelper.FilterTag(torrent, tag));
}
torrentList.CategoriesState[FilterHelper.CATEGORY_UNCATEGORIZED].AddIfTrueOrRemove(hash, FilterHelper.FilterCategory(torrent, FilterHelper.CATEGORY_UNCATEGORIZED, torrentList.ServerState.UseSubcategories));
foreach (var category in torrentList.Categories.Keys)
{
if (!torrentList.CategoriesState.TryGetValue(category, out HashSet<string>? value))
{
value = [];
torrentList.CategoriesState.Add(category, value);
}
value.AddIfTrueOrRemove(hash, FilterHelper.FilterCategory(torrent, category, torrentList.ServerState.UseSubcategories));
}
foreach (var status in GetStatuses(torrentList.MajorVersion))
{
torrentList.StatusState[status.ToString()].AddIfTrueOrRemove(hash, FilterHelper.FilterStatus(torrent, status));
}
torrentList.TrackersState[FilterHelper.TRACKER_TRACKERLESS].AddIfTrueOrRemove(hash, FilterHelper.FilterTracker(torrent, FilterHelper.TRACKER_TRACKERLESS));
foreach (var tracker in torrentList.Trackers.Keys)
{
if (!torrentList.TrackersState.TryGetValue(tracker, out HashSet<string>? value))
{
value = [];
torrentList.TrackersState.Add(tracker, value);
}
value.AddIfTrueOrRemove(hash, FilterHelper.FilterTracker(torrent, tracker));
}
UpdateTagStateForUpdate(torrentList, hash, previousSnapshot.Tags, updatedTorrent.Tags);
UpdateCategoryState(torrentList, updatedTorrent, hash, previousSnapshot.Category);
UpdateStatusState(torrentList, hash, previousSnapshot.State, previousSnapshot.UploadSpeed, updatedTorrent.State, updatedTorrent.UploadSpeed);
UpdateTrackerState(torrentList, updatedTorrent, hash, previousSnapshot.Tracker);
}
private static void RemoveTorrentFromStates(MainData torrentList, string hash)
{
var torrent = torrentList.Torrents[hash];
if (!torrentList.Torrents.TryGetValue(hash, out var torrent))
{
return;
}
var snapshot = CreateSnapshot(torrent);
torrentList.TagState[FilterHelper.TAG_ALL].Remove(hash);
torrentList.TagState[FilterHelper.TAG_UNTAGGED].RemoveIfTrue(hash, FilterHelper.FilterTag(torrent, FilterHelper.TAG_UNTAGGED));
foreach (var tag in torrentList.Tags)
{
if (!torrentList.TagState.TryGetValue(tag, out var tagState))
{
continue;
}
tagState.RemoveIfTrue(hash, FilterHelper.FilterTag(torrent, tag));
}
UpdateTagStateForRemoval(torrentList, hash, snapshot.Tags);
torrentList.CategoriesState[FilterHelper.CATEGORY_ALL].Remove(hash);
torrentList.CategoriesState[FilterHelper.CATEGORY_UNCATEGORIZED].RemoveIfTrue(hash, FilterHelper.FilterCategory(torrent, FilterHelper.CATEGORY_UNCATEGORIZED, torrentList.ServerState.UseSubcategories));
foreach (var category in torrentList.Categories.Keys)
{
if (!torrentList.CategoriesState.TryGetValue(category, out var categoryState))
{
continue;
}
categoryState.RemoveIfTrue(hash, FilterHelper.FilterCategory(torrent, category, torrentList.ServerState.UseSubcategories));
}
UpdateCategoryStateForRemoval(torrentList, hash, snapshot.Category);
foreach (var status in GetStatuses(torrentList.MajorVersion))
{
@@ -441,19 +395,15 @@ namespace Lantean.QBTMud.Services
{
continue;
}
statusState.RemoveIfTrue(hash, FilterHelper.FilterStatus(torrent, status));
if (FilterHelper.FilterStatus(snapshot.State, snapshot.UploadSpeed, status))
{
statusState.Remove(hash);
}
}
torrentList.TrackersState[FilterHelper.TRACKER_ALL].Remove(hash);
torrentList.TrackersState[FilterHelper.TRACKER_TRACKERLESS].RemoveIfTrue(hash, FilterHelper.FilterTracker(torrent, FilterHelper.TRACKER_TRACKERLESS));
foreach (var tracker in torrentList.Trackers.Keys)
{
if (!torrentList.TrackersState.TryGetValue(tracker, out var trackerState))
{
continue;
}
trackerState.RemoveIfTrue(hash, FilterHelper.FilterTracker(torrent, tracker));
}
UpdateTrackerStateForRemoval(torrentList, hash, snapshot.Tracker);
}
private static bool UpdateServerState(ServerState existingServerState, QBitTorrentClient.Models.ServerState serverState)
@@ -689,6 +639,12 @@ namespace Lantean.QBTMud.Services
public Torrent CreateTorrent(string hash, QBitTorrentClient.Models.Torrent torrent)
{
var normalizedTags = torrent.Tags?
.Select(NormalizeTag)
.Where(static tag => !string.IsNullOrEmpty(tag))
.ToList()
?? new List<string>();
return new Torrent(
hash,
torrent.AddedOn.GetValueOrDefault(),
@@ -729,7 +685,7 @@ namespace Lantean.QBTMud.Services
torrent.Size.GetValueOrDefault(),
torrent.State!,
torrent.SuperSeeding.GetValueOrDefault(),
torrent.Tags!,
normalizedTags,
torrent.TimeActive.GetValueOrDefault(),
torrent.TotalSize.GetValueOrDefault(),
torrent.Tracker!,
@@ -742,6 +698,288 @@ namespace Lantean.QBTMud.Services
torrent.MaxInactiveSeedingTime.GetValueOrDefault());
}
private static string NormalizeTag(string? tag)
{
if (string.IsNullOrEmpty(tag))
{
return string.Empty;
}
var separatorIndex = tag.IndexOf('\t');
var normalized = (separatorIndex >= 0) ? tag[..separatorIndex] : tag;
return normalized.Trim();
}
private static TorrentSnapshot CreateSnapshot(Torrent torrent)
{
return new TorrentSnapshot(
string.IsNullOrEmpty(torrent.Category) ? null : torrent.Category,
torrent.Tags.ToList(),
torrent.Tracker ?? string.Empty,
torrent.State ?? string.Empty,
torrent.UploadSpeed);
}
private readonly struct TorrentSnapshot
{
public TorrentSnapshot(string? category, List<string> tags, string tracker, string state, long uploadSpeed)
{
Category = category;
Tags = tags;
Tracker = tracker;
State = state;
UploadSpeed = uploadSpeed;
}
public string? Category { get; }
public IReadOnlyList<string> Tags { get; }
public string Tracker { get; }
public string State { get; }
public long UploadSpeed { get; }
}
private static void UpdateTagStateForAddition(MainData torrentList, Torrent torrent, string hash)
{
if (torrent.Tags.Count == 0)
{
torrentList.TagState[FilterHelper.TAG_UNTAGGED].Add(hash);
return;
}
torrentList.TagState[FilterHelper.TAG_UNTAGGED].Remove(hash);
foreach (var tag in torrent.Tags)
{
if (string.IsNullOrEmpty(tag))
{
continue;
}
GetOrCreateTagSet(torrentList, tag).Add(hash);
}
}
private static void UpdateTagStateForUpdate(MainData torrentList, string hash, IReadOnlyList<string> previousTags, IList<string> newTags)
{
UpdateTagStateForRemoval(torrentList, hash, previousTags);
if (newTags.Count == 0)
{
torrentList.TagState[FilterHelper.TAG_UNTAGGED].Add(hash);
return;
}
torrentList.TagState[FilterHelper.TAG_UNTAGGED].Remove(hash);
foreach (var tag in newTags)
{
if (string.IsNullOrEmpty(tag))
{
continue;
}
GetOrCreateTagSet(torrentList, tag).Add(hash);
}
}
private static void UpdateTagStateForRemoval(MainData torrentList, string hash, IReadOnlyList<string> previousTags)
{
torrentList.TagState[FilterHelper.TAG_UNTAGGED].Remove(hash);
foreach (var tag in previousTags)
{
if (string.IsNullOrEmpty(tag))
{
continue;
}
if (torrentList.TagState.TryGetValue(tag, out var set))
{
set.Remove(hash);
}
}
}
private static void UpdateCategoryState(MainData torrentList, Torrent updatedTorrent, string hash, string? previousCategory)
{
var useSubcategories = torrentList.ServerState.UseSubcategories;
if (!string.IsNullOrEmpty(previousCategory))
{
foreach (var categoryKey in EnumerateCategoryKeys(previousCategory, useSubcategories))
{
if (torrentList.CategoriesState.TryGetValue(categoryKey, out var set))
{
set.Remove(hash);
}
}
}
else
{
torrentList.CategoriesState[FilterHelper.CATEGORY_UNCATEGORIZED].Remove(hash);
}
if (string.IsNullOrEmpty(updatedTorrent.Category))
{
torrentList.CategoriesState[FilterHelper.CATEGORY_UNCATEGORIZED].Add(hash);
return;
}
foreach (var categoryKey in EnumerateCategoryKeys(updatedTorrent.Category, useSubcategories))
{
GetOrCreateCategorySet(torrentList, categoryKey).Add(hash);
}
}
private static void UpdateCategoryStateForRemoval(MainData torrentList, string hash, string? previousCategory)
{
if (string.IsNullOrEmpty(previousCategory))
{
torrentList.CategoriesState[FilterHelper.CATEGORY_UNCATEGORIZED].Remove(hash);
return;
}
foreach (var categoryKey in EnumerateCategoryKeys(previousCategory, torrentList.ServerState.UseSubcategories))
{
if (torrentList.CategoriesState.TryGetValue(categoryKey, out var set))
{
set.Remove(hash);
}
}
}
private static void UpdateStatusState(MainData torrentList, string hash, string previousState, long previousUploadSpeed, string newState, long newUploadSpeed)
{
foreach (var status in GetStatuses(torrentList.MajorVersion))
{
if (!torrentList.StatusState.TryGetValue(status.ToString(), out var statusSet))
{
continue;
}
var wasMatch = FilterHelper.FilterStatus(previousState, previousUploadSpeed, status);
var isMatch = FilterHelper.FilterStatus(newState, newUploadSpeed, status);
if (wasMatch == isMatch)
{
continue;
}
if (wasMatch)
{
statusSet.Remove(hash);
}
if (isMatch)
{
statusSet.Add(hash);
}
}
}
private static void UpdateTrackerState(MainData torrentList, Torrent updatedTorrent, string hash, string? previousTracker)
{
if (!string.IsNullOrEmpty(previousTracker))
{
if (torrentList.TrackersState.TryGetValue(previousTracker, out var oldSet))
{
oldSet.Remove(hash);
}
}
else
{
torrentList.TrackersState[FilterHelper.TRACKER_TRACKERLESS].Remove(hash);
}
var tracker = updatedTorrent.Tracker ?? string.Empty;
if (string.IsNullOrEmpty(tracker))
{
torrentList.TrackersState[FilterHelper.TRACKER_TRACKERLESS].Add(hash);
return;
}
torrentList.TrackersState[FilterHelper.TRACKER_TRACKERLESS].Remove(hash);
GetOrCreateTrackerSet(torrentList, tracker).Add(hash);
}
private static void UpdateTrackerStateForRemoval(MainData torrentList, string hash, string? previousTracker)
{
if (string.IsNullOrEmpty(previousTracker))
{
torrentList.TrackersState[FilterHelper.TRACKER_TRACKERLESS].Remove(hash);
return;
}
if (torrentList.TrackersState.TryGetValue(previousTracker, out var trackerSet))
{
trackerSet.Remove(hash);
}
}
private static IEnumerable<string> EnumerateCategoryKeys(string category, bool useSubcategories)
{
if (string.IsNullOrEmpty(category))
{
yield break;
}
yield return category;
if (!useSubcategories)
{
yield break;
}
var current = category;
while (true)
{
var separatorIndex = current.LastIndexOf('/');
if (separatorIndex < 0)
{
yield break;
}
current = current[..separatorIndex];
yield return current;
}
}
private static HashSet<string> GetOrCreateTagSet(MainData torrentList, string tag)
{
if (!torrentList.TagState.TryGetValue(tag, out var set))
{
set = new HashSet<string>(StringComparer.Ordinal);
torrentList.TagState[tag] = set;
}
return set;
}
private static HashSet<string> GetOrCreateCategorySet(MainData torrentList, string category)
{
if (!torrentList.CategoriesState.TryGetValue(category, out var set))
{
set = new HashSet<string>(StringComparer.Ordinal);
torrentList.CategoriesState[category] = set;
}
return set;
}
private static HashSet<string> GetOrCreateTrackerSet(MainData torrentList, string tracker)
{
if (!torrentList.TrackersState.TryGetValue(tracker, out var set))
{
set = new HashSet<string>(StringComparer.Ordinal);
torrentList.TrackersState[tracker] = set;
}
return set;
}
private static bool UpdateCategory(Category existingCategory, QBitTorrentClient.Models.Category category)
{
if (category.SavePath is not null && existingCategory.SavePath != category.SavePath)
@@ -1004,10 +1242,14 @@ namespace Lantean.QBTMud.Services
if (torrent.Tags is not null)
{
if (!existingTorrent.Tags.SequenceEqual(torrent.Tags))
var normalizedTags = torrent.Tags.Select(NormalizeTag)
.Where(static tag => !string.IsNullOrEmpty(tag))
.ToList();
if (!existingTorrent.Tags.SequenceEqual(normalizedTags))
{
existingTorrent.Tags.Clear();
existingTorrent.Tags.AddRange(torrent.Tags);
existingTorrent.Tags.AddRange(normalizedTags);
dataChanged = true;
filterChanged = true;
}