From 22d7ef5615ae3a61bd0c1d0fcfa0561ffe280c8c Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Tue, 5 May 2020 11:50:31 -0700 Subject: [PATCH] main: Turn electron-connect off by default. Signed-off-by: Anders Kaseorg --- app/renderer/js/main.ts | 6 ++---- gulpfile.js | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/app/renderer/js/main.ts b/app/renderer/js/main.ts index fd034d1a..737acfe9 100644 --- a/app/renderer/js/main.ts +++ b/app/renderer/js/main.ts @@ -1069,10 +1069,8 @@ class ServerManagerView { window.addEventListener('load', async () => { // Only start electron-connect (auto reload on change) when its ran - // from `npm run dev` or `gulp dev` and not from `npm start` when - // app is started `npm start` main process's proces.argv will have - // `--no-electron-connect` - if (isDev && !remote.getGlobal('process').argv.includes('--no-electron-connect')) { + // from `npm run dev` or `gulp dev` and not from `npm start` + if (isDev && remote.getGlobal('process').argv.includes('--electron-connect')) { require('electron-connect').client.create(); } diff --git a/gulpfile.js b/gulpfile.js index 712ed3fc..cdfb559f 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -29,7 +29,7 @@ gulp.task('compile', () => { gulp.task('dev', () => { // Start browser process - electron.start(); + electron.start(['--electron-connect']); // Restart browser process gulp.watch('app/main/*.ts', gulp.series('compile', 'restart:browser')); // Reload renderer process @@ -40,7 +40,7 @@ gulp.task('dev', () => { gulp.task('restart:browser', done => { electron.stop(); - electron.restart(); + electron.restart(['--electron-connect']); done(); });