paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-10-24 08:33:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

electron_bridge: Make the options argument of new_notification required.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-04-02 15:05:52 -07:00
parent 1e10a3c406
commit 4f58a2a357
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/renderer/js/electron-bridge.ts
View File

@@ -25,7 +25,7 @@ const electron_bridge: ElectronBridge = {
new_notification: ( new_notification: (
title: string, title: string,
options: NotificationOptions | undefined, options: NotificationOptions,
dispatch: (type: string, eventInit: EventInit) => boolean, dispatch: (type: string, eventInit: EventInit) => boolean,
): NotificationData => newNotification(title, options, dispatch), ): NotificationData => newNotification(title, options, dispatch),

2
app/renderer/js/injected.ts
View File

@@ -69,7 +69,7 @@ interface CompatElectronBridge extends ElectronBridge {
const NativeNotification = Notification; const NativeNotification = Notification;
class InjectedNotification extends EventTarget { class InjectedNotification extends EventTarget {
constructor(title: string, options?: NotificationOptions) { constructor(title: string, options: NotificationOptions = {}) {
super(); super();
Object.assign( Object.assign(
this, this,

2
app/renderer/js/notification/index.ts
View File

@@ -30,7 +30,7 @@ export interface NotificationData {
export function newNotification( export function newNotification(
title: string, title: string,
options: NotificationOptions | undefined, options: NotificationOptions,
dispatch: (type: string, eventInit: EventInit) => boolean, dispatch: (type: string, eventInit: EventInit) => boolean,
): NotificationData { ): NotificationData {
const notification = new DefaultNotification(title, options); const notification = new DefaultNotification(title, options);

2
typings.d.ts vendored
View File

@@ -32,7 +32,7 @@ interface ElectronBridge {
on_event: (eventName: string, listener: ListenerType) => void; on_event: (eventName: string, listener: ListenerType) => void;
new_notification: ( new_notification: (
title: string, title: string,
options: NotificationOptions | undefined, options: NotificationOptions,
dispatch: (type: string, eventInit: EventInit) => boolean, dispatch: (type: string, eventInit: EventInit) => boolean,
) => NotificationData; ) => NotificationData;
get_idle_on_system: () => boolean; get_idle_on_system: () => boolean;