mirror of
				https://github.com/zulip/zulip-desktop.git
				synced 2025-11-03 21:43:18 +00:00 
			
		
		
		
	settings: Fix app settings overriding issue. (#449)
This fixes an issue which was caused by saving the last active tab
before a functional tab activates. The bug was introduced in f409bb0449.
It was unnoticed from v1.5.0 to the latest v1.8.2.
The bug causes a serious issue where the app can't change the app settings and all settings were
getting overridden when a user switches back to setting page.
Fixes #448.
			
			
This commit is contained in:
		@@ -268,10 +268,10 @@ class ServerManagerView {
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	activateLastTab(index) {
 | 
			
		||||
		// Open last active tab
 | 
			
		||||
		ConfigUtil.setConfigItem('lastActiveTab', index);
 | 
			
		||||
		// Open all the tabs in background
 | 
			
		||||
		// Open all the tabs in background, also activate the tab based on the index
 | 
			
		||||
		this.activateTab(index);
 | 
			
		||||
		// Save last active tab
 | 
			
		||||
		ConfigUtil.setConfigItem('lastActiveTab', index);
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	activateTab(index, hideOldTab = true) {
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user