mirror of
				https://github.com/zulip/zulip-desktop.git
				synced 2025-11-03 21:43:18 +00:00 
			
		
		
		
	Add setting to control Windows taskbar flashing #299
This commit is contained in:
		@@ -45,7 +45,7 @@ class BadgeSettings {
 | 
			
		||||
 | 
			
		||||
	updateOverlayIcon(messageCount, mainWindow) {
 | 
			
		||||
		if (!mainWindow.isFocused()) {
 | 
			
		||||
			mainWindow.flashFrame(true);
 | 
			
		||||
			mainWindow.flashFrame(ConfigUtil.getConfigItem('flashTaskbarOnMessage'));
 | 
			
		||||
		}
 | 
			
		||||
		if (messageCount === 0) {
 | 
			
		||||
			mainWindow.setOverlayIcon(null, '');
 | 
			
		||||
 
 | 
			
		||||
@@ -29,9 +29,13 @@ class GeneralSection extends BaseSection {
 | 
			
		||||
						<div class="setting-control"></div>
 | 
			
		||||
					</div>
 | 
			
		||||
					<div class="setting-row" id="badge-option">
 | 
			
		||||
					<div class="setting-description">Show app unread badge</div>
 | 
			
		||||
					<div class="setting-control"></div>
 | 
			
		||||
				</div>
 | 
			
		||||
						<div class="setting-description">Show app unread badge</div>
 | 
			
		||||
						<div class="setting-control"></div>
 | 
			
		||||
					</div>
 | 
			
		||||
					<div class="setting-row" id="flash-taskbar-option">
 | 
			
		||||
						<div class="setting-description">Flash taskbar on New message</div>
 | 
			
		||||
						<div class="setting-control"></div>
 | 
			
		||||
					</div>
 | 
			
		||||
				</div>
 | 
			
		||||
				<div class="title">Desktop Notification</div>
 | 
			
		||||
				<div class="settings-card">
 | 
			
		||||
@@ -78,6 +82,7 @@ class GeneralSection extends BaseSection {
 | 
			
		||||
		this.props.$root.innerHTML = this.template();
 | 
			
		||||
		this.updateTrayOption();
 | 
			
		||||
		this.updateBadgeOption();
 | 
			
		||||
		this.updateFlashTaskbar();
 | 
			
		||||
		this.updateUpdateOption();
 | 
			
		||||
		this.updateSilentOption();
 | 
			
		||||
		this.updateSidebarOption();
 | 
			
		||||
@@ -113,6 +118,18 @@ class GeneralSection extends BaseSection {
 | 
			
		||||
		});
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	updateFlashTaskbar() {
 | 
			
		||||
		this.generateSettingOption({
 | 
			
		||||
			$element: document.querySelector('#flash-taskbar-option .setting-control'),
 | 
			
		||||
			value: ConfigUtil.getConfigItem('flashTaskbarOnMessage', true),
 | 
			
		||||
			clickHandler: () => {
 | 
			
		||||
				const newValue = !ConfigUtil.getConfigItem('flashTaskbarOnMessage');
 | 
			
		||||
				ConfigUtil.setConfigItem('flashTaskbarOnMessage', newValue);
 | 
			
		||||
				this.updateFlashTaskbar();
 | 
			
		||||
			}
 | 
			
		||||
		});
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	updateUpdateOption() {
 | 
			
		||||
		this.generateSettingOption({
 | 
			
		||||
			$element: document.querySelector('#betaupdate-option .setting-control'),
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user