paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-02 04:53:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix handling of server icon updates and errors.

Browse Source 
Fixes #1283.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2023-04-21 15:33:16 -07:00
parent 6e8fe36876
commit 77638f6287
4 changed files with 33 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/main/request.ts
View File

@@ -30,8 +30,6 @@ const pipeline = util.promisify(stream.pipeline);
/* Request: domain-util */
const defaultIconUrl = "../renderer/img/icon.png";
const logger = new Logger({
file: "domain-util.log",
});
@@ -94,12 +92,12 @@ export const _getServerSettings = async (
export const _saveServerIcon = async (
url: string,
session: Session,
): Promise<string> => {
): Promise<string | null> => {
try {
const response = await fetchResponse(net.request({url, session}));
if (response.statusCode !== 200) {
logger.log("Could not get server icon.");
return defaultIconUrl;
return null;
}
const filePath = generateFilePath(url);
@@ -109,7 +107,7 @@ export const _saveServerIcon = async (
logger.log("Could not get server icon.");
logger.log(error);
Sentry.captureException(error);
return defaultIconUrl;
return null;
}
};