xo: Enable import/no-mutable-exports.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>

app/renderer/js/main.ts

@@ -141,7 +141,7 @@ class ServerManagerView {
 		this.initDefaultSettings();
 		this.initSidebar();
 		this.removeUAfromDisk();
-		if (EnterpriseUtil.configFile) {
+		if (EnterpriseUtil.hasConfigFile()) {
 			await this.initPresetOrgs();
 		}
 
@@ -946,8 +946,7 @@ class ServerManagerView {
 					this.tabs[index].webview.props.name = realmName;
 
 					domain.alias = escape(realmName);
-					DomainUtil.db.push(`/domains[${index}]`, domain, true);
-					DomainUtil.reloadDB();
+					DomainUtil.updateDomain(index, domain);
 					// Update the realm name also on the Window menu
 					ipcRenderer.send('update-menu', {
 						tabs: this.tabsForIpc,
@@ -968,8 +967,7 @@ class ServerManagerView {
 					const serverImgs: NodeListOf<HTMLImageElement> = document.querySelectorAll(serverImgsSelector);
 					serverImgs[index].src = localIconUrl;
 					domain.icon = localIconUrl;
-					DomainUtil.db.push(`/domains[${index}]`, domain, true);
-					DomainUtil.reloadDB();
+					DomainUtil.updateDomain(index, domain);
 				}
 			});
 		});

app/renderer/js/utils/domain-util.ts

@@ -27,7 +27,7 @@ const logger = new Logger({
 
 const defaultIconUrl = '../renderer/img/icon.png';
 
-export let db: JsonDB;
+let db: JsonDB;
 
 reloadDB();
 // Migrate from old schema
@@ -66,7 +66,7 @@ export function shouldIgnoreCerts(url: string): boolean {
 	return null;
 }
 
-function updateDomain(index: number, server: ServerConf): void {
+export function updateDomain(index: number, server: ServerConf): void {
 	reloadDB();
 	db.push(`/domains[${index}]`, server, true);
 }
@@ -267,7 +267,7 @@ export async function updateSavedServer(url: string, index: number): Promise<voi
 	}
 }
 
-export function reloadDB(): void {
+function reloadDB(): void {
 	const domainJsonPath = path.join(app.getPath('userData'), 'config/domain.json');
 	try {
 		const file = fs.readFileSync(domainJsonPath, 'utf8');

app/renderer/js/utils/enterprise-util.ts

@@ -9,8 +9,8 @@ const logger = new Logger({
 });
 
 // TODO: replace enterpriseSettings type with an interface once settings are final
-export let enterpriseSettings: any;
-export let configFile: boolean;
+let enterpriseSettings: any;
+let configFile: boolean;
 
 reloadDB();
 
@@ -35,6 +35,10 @@ function reloadDB(): void {
 	}
 }
 
+export function hasConfigFile(): boolean {
+	return configFile;
+}
+
 export function getConfigItem(key: string, defaultValue?: any): any {
 	reloadDB();
 	if (!configFile) {

package.json

@@ -204,7 +204,6 @@
     "rules": {
       "@typescript-eslint/no-dynamic-delete": "off",
       "@typescript-eslint/prefer-readonly-parameter-types": "off",
-      "import/no-mutable-exports": "off",
       "import/unambiguous": "error",
       "max-lines": [
         "warn",