paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-03 21:43:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify querySelectorAll(…)[0] to querySelector(…).

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-03-31 16:06:32 -07:00
parent 67228d295d
commit b07995c3ed
5 changed files with 14 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/renderer/js/components/functional-tab.ts
View File

@@ -29,7 +29,7 @@ export default class FunctionalTab extends Tab {
this.$el = this.generateNodeFromHTML(this.templateHTML()); this.$el = this.generateNodeFromHTML(this.templateHTML());
if (this.props.name !== "Settings") { if (this.props.name !== "Settings") {
this.props.$root.append(this.$el); this.props.$root.append(this.$el);
this.$closeButton = this.$el.querySelectorAll(".server-tab-badge")[0]; this.$closeButton = this.$el.querySelector(".server-tab-badge");
this.registerListeners(); this.registerListeners();
} }
} }

2
app/renderer/js/components/server-tab.ts
View File

@@ -34,7 +34,7 @@ export default class ServerTab extends Tab {
this.$el = this.generateNodeFromHTML(this.templateHTML()); this.$el = this.generateNodeFromHTML(this.templateHTML());
this.props.$root.append(this.$el); this.props.$root.append(this.$el);
this.registerListeners(); this.registerListeners();
this.$badge = this.$el.querySelectorAll(".server-tab-badge")[0]; this.$badge = this.$el.querySelector(".server-tab-badge");
} }
updateBadge(count: number): void { updateBadge(count: number): void {

4
app/renderer/js/pages/preference/find-accounts.ts
View File

@@ -40,9 +40,9 @@ export default class FindAccounts extends BaseComponent {
this.$findAccountsButton = this.$findAccounts.querySelector( this.$findAccountsButton = this.$findAccounts.querySelector(
"#find-accounts-button", "#find-accounts-button",
); );
this.$serverUrlField = this.$findAccounts.querySelectorAll( this.$serverUrlField = this.$findAccounts.querySelector(
"input.setting-input-value", "input.setting-input-value",
)[0] as HTMLInputElement; );
this.initListeners(); this.initListeners();
} }

8
app/renderer/js/pages/preference/new-server-form.ts
View File

@@ -72,9 +72,9 @@ export default class NewServerForm extends BaseComponent {
this.$saveServerButton = this.$newServerForm.querySelector("#connect"); this.$saveServerButton = this.$newServerForm.querySelector("#connect");
this.props.$root.textContent = ""; this.props.$root.textContent = "";
this.props.$root.append(this.$newServerForm); this.props.$root.append(this.$newServerForm);
this.$newServerUrl = this.$newServerForm.querySelectorAll( this.$newServerUrl = this.$newServerForm.querySelector(
"input.setting-input-value", "input.setting-input-value",
)[0] as HTMLInputElement; );
} }
async submitFormHandler(): Promise<void> { async submitFormHandler(): Promise<void> {
@@ -112,9 +112,7 @@ export default class NewServerForm extends BaseComponent {
} }
networkSettingsLink(): void { networkSettingsLink(): void {
const networkSettingsId = document.querySelectorAll( const networkSettingsId = document.querySelector(".server-network-option");
".server-network-option",
)[0];
networkSettingsId.addEventListener("click", () => { networkSettingsId.addEventListener("click", () => {
ipcRenderer.send("forward-message", "open-network-settings"); ipcRenderer.send("forward-message", "open-network-settings");
}); });

16
app/renderer/js/pages/preference/server-info-form.ts
View File

@@ -62,18 +62,16 @@ export default class ServerInfoForm extends BaseComponent {
initForm(): void { initForm(): void {
this.$serverInfoForm = this.generateNodeFromHTML(this.templateHTML()); this.$serverInfoForm = this.generateNodeFromHTML(this.templateHTML());
this.$serverInfoAlias = this.$serverInfoForm.querySelectorAll( this.$serverInfoAlias = this.$serverInfoForm.querySelector(
".server-info-alias", ".server-info-alias",
)[0]; );
this.$serverIcon = this.$serverInfoForm.querySelectorAll( this.$serverIcon = this.$serverInfoForm.querySelector(".server-info-icon");
".server-info-icon", this.$deleteServerButton = this.$serverInfoForm.querySelector(
)[0];
this.$deleteServerButton = this.$serverInfoForm.querySelectorAll(
".server-delete-action", ".server-delete-action",
)[0]; );
this.$openServerButton = this.$serverInfoForm.querySelectorAll( this.$openServerButton = this.$serverInfoForm.querySelector(
".open-tab-button", ".open-tab-button",
)[0]; );
this.props.$root.append(this.$serverInfoForm); this.props.$root.append(this.$serverInfoForm);
} }