paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-10-29 02:53:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings-tab: Do not create a sidebar tab rather highlight bottom settings icon. (#422)

Browse Source 
Creating the new functional tab for setting tab was unnecessary as we already have a sticky setting icon at the bottom. This PR adds a functionality to highlight that settings icon instead of creating the new one.

Fixes: #418.
This commit is contained in:
Abhigyan Khaund
2018-02-23 19:03:30 +05:30
committed by Akash Nimare
parent fd421a62d2
commit b83e2dd428
4 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/renderer/js/components/functional-tab.js
View File

@@ -16,10 +16,11 @@ class FunctionalTab extends Tab {
init() {
this.$el = this.generateNodeFromTemplate(this.template());
this.props.$root.appendChild(this.$el);
this.$closeButton = this.$el.getElementsByClassName('server-tab-badge')[0];
this.registerListeners();
if (this.props.name !== 'Settings') {
this.props.$root.appendChild(this.$el);
this.$closeButton = this.$el.getElementsByClassName('server-tab-badge')[0];
this.registerListeners();
}
}
registerListeners() {