From bda0dd29dfb45c95e6e6bb86752e00a2026241bc Mon Sep 17 00:00:00 2001 From: Abhigyan Khaund <20434085+abhigyank@users.noreply.github.com> Date: Fri, 26 Jun 2020 17:01:44 +0530 Subject: [PATCH] context-menu: Fix bug in Copy Link and add copy Email. Fixes: #986 --- app/renderer/js/components/context-menu.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/app/renderer/js/components/context-menu.ts b/app/renderer/js/components/context-menu.ts index 96f83f23..948117b5 100644 --- a/app/renderer/js/components/context-menu.ts +++ b/app/renderer/js/components/context-menu.ts @@ -5,6 +5,7 @@ const {clipboard, Menu} = remote; export const contextMenu = (webContents: Electron.WebContents, event: Event, props: ContextMenuParams) => { const isText = Boolean(props.selectionText.length); const isLink = Boolean(props.linkURL); + const isEmailAddress = Boolean(props.linkURL.startsWith('mailto:')); const makeSuggestion = (suggestion: string) => ({ label: suggestion, @@ -55,12 +56,12 @@ export const contextMenu = (webContents: Electron.WebContents, event: Event, pro }, { type: 'separator' }, { - label: t.__('Copy Link'), - visible: isText && isLink, + label: isEmailAddress ? t.__('Copy Email Address') : t.__('Copy Link'), + visible: isLink, click(_item) { clipboard.write({ bookmark: props.linkText, - text: props.linkURL + text: isEmailAddress ? props.linkText : props.linkURL }); } }, {