paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-03 05:23:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,899 Commits 27 Branches 70 Tags
0c784b12faf9afd5fbf9f3771eb0ca71f4957d0f
Commit Graph

827 Commits

Author SHA1 Message Date
Anders Kaseorg
0c784b12fa WebView: Enable allowpopups. 
This is required for Electron ≥ 15 to continue invoking our new window
handler (handleExternalLink), following the nativeWindowOpen
migration.

https://github.com/electron/electron/issues/30886

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-11 18:23:39 -08:00
Anders Kaseorg
4151e020f6 Revert "xo: Fix import/extensions." 
This reverts commit 5623ab3866.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:58:40 -08:00
Anders Kaseorg
bc59714192 xo: Fix @typescript-eslint/naming-convention. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:24:49 -08:00
Anders Kaseorg
b43a7b6809 xo: Fix unicorn/template-indent. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:15:32 -08:00
Anders Kaseorg
fba8aa0ab0 xo: Fix object-shorthand. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:15:32 -08:00
Anders Kaseorg
5623ab3866 xo: Fix import/extensions. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:15:32 -08:00
Anders Kaseorg
1ea7fa813a Remove redundant webPreferences defaults. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:15:22 -08:00
Anders Kaseorg
e434c5b5d0 Untangle Sentry initialization. 
Thanks to upstream for the helpful advice at
https://github.com/getsentry/sentry-electron/issues/427.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 16:55:36 -08:00
Anders Kaseorg
4ed4328bf8 Toggle spell checker in the session rather than the webPreferences. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 16:05:54 -08:00
Anders Kaseorg
06eb169c65 WebView: Restrict $el type to HTMLElement. 
The extra methods on WebviewTag are not available from the
context-isolated preload script.
https://github.com/electron/electron/issues/26904

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
2f7529cd71 WebView: Get event parameters via WebContents rather than WebviewTag. 
Works around https://github.com/electron/electron/issues/31924.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
3a8541f601 WebView: Call getWebContentsId in main world. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
0eb910b2e8 WebView: Use send method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
76a879e4fd WebView: Convert WebviewTag methods to WebContents methods. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
7026e43575 WebView: Add getWebContents method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
869361bac3 WebView: Type $el as required. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
832ea3c04e WebView: Remove async from send method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
68232f966e WebView: Wait for did-navigate before constructing WebView. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
86b7da45ef WebView: Use a better focus() workaround. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
b853856317 WebView: Add factory function. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
6676f1c6ac WebView: Switch templateHTML to a static method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
fd6cb548f8 WebView: Remove nodeIntegration parameter. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
743b2d6054 WebView: Make preload a string. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
fb5c6b365e css: Simplify webview CSS. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
f092e99f42 css: Remove the melodramatic fade-in animation on load. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
751eb6ef98 Switch electron.remote to @electron/remote. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
84849d2c84 Move functional tab pages out of separate webviews. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:42:04 -08:00
Anders Kaseorg
b263997bed tray: Move initialization to a function. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:07:37 -08:00
Anders Kaseorg
12c773bc71 tray: Be robust in case there’s no active webview. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:07:33 -08:00
Anders Kaseorg
d937539618 renderer: Restrict webview functions to ServerTab instances. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:07:28 -08:00
Anders Kaseorg
0a5d07f839 renderer: Inline FunctionalTabProps type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:07:23 -08:00
Anders Kaseorg
5dcd3956ac preference: Unify duplicate toggle-sidebar-setting event. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:07:21 -08:00
Anders Kaseorg
3ffc7251f4 preference: Unify duplicate toggle-menubar-setting event. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:06:09 -08:00
Anders Kaseorg
7fb0cfd176 WebView: Remove redundant name property. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:05:25 -08:00
Anders Kaseorg
5c83952ba1 webview: Remove forceLoad method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:04:29 -08:00
Anders Kaseorg
a7a051bb2a renderer: Remove dead show-network-error message. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:04:21 -08:00
Anders Kaseorg
2b2c5dbe5c about: Encapsulate in a custom element. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:04:20 -08:00
Anders Kaseorg
ffe87a9729 preference: Encapsulate in a custom element. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 15:58:36 -08:00
Anders Kaseorg
f9f2b20e90 preference: Use querySelector relative to $root. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-17 22:45:10 -08:00
Anders Kaseorg
f66a1127de electron-bridge: Remove console.log debugging spew. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-03 23:09:50 -08:00
Anders Kaseorg
06ef60c4c2 notification: Remove BaseNotification wrapper class. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-03 23:02:37 -08:00
Anders Kaseorg
4b93298b58 notification: Set the AppUserModelId from the main process. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-03 22:55:15 -08:00
Anders Kaseorg
a41a771923 notification: Don’t use remote for focusCurrentServer. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-03 22:54:38 -08:00
Anders Kaseorg
525fa94b18 Fix system proxy resolution. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-11-23 17:51:51 -08:00
Anders Kaseorg
8fc41a7ca8 system-util: Remove getOS wrapper. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-11-22 15:56:58 -08:00
Anders Kaseorg
4c7b9cf4e3 server-tab: Delete space in macOS shortcut text. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-11-22 15:50:32 -08:00
Anders Kaseorg
377f08ad5d Fix unread count parsing from page title. 
Fixes #1157

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-27 16:42:46 -07:00
Anders Kaseorg
b35d45955b WebView: Move initialization from dom-ready event to did-attach event. 
This fixes the bug where the context menu would disappear immediately
if the page had been loaded an even number of times.

Fixes #662, fixes #991, fixes #1010.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-08 18:10:43 -07:00
Anders Kaseorg
2ecb970da0 Revert "webview: fix focus after soft reload." 
This reverts commit 6b98a49245 (#698).

The bug it worked around was fixed upstream in Electron 9.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-08 16:32:10 -07:00
Anders Kaseorg
4db89ac3a7 typescript: Enable noImplicitOverride. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-09-10 21:52:32 -07:00