Anders Kaseorg
55eb768064
xo: Upgrade xo to 0.28.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-23 16:53:14 -07:00
Anders Kaseorg
611932c66d
xo: Unabbreviate variable names.
...
To satisfy unicorn/prevent-abbreviations in xo 0.28.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-23 16:53:12 -07:00
Anders Kaseorg
5deffa5022
changelog: Add missing changelog entry for v4.0.3.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-23 15:08:21 -07:00
Anders Kaseorg
6f01f1362a
js: Declare 'use strict' on tests too.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-09 22:14:23 -07:00
Anders Kaseorg
9d2739f050
js: Declare 'use strict' on all scripts and no modules.
...
And enable the import/unambiguous ESLint rule as a check on our
partition between scripts and modules. After this commit, if you add
a new file and get this error:
✖ 1:1 This module could be parsed as a valid script. import/unambiguous
* For a module, add an `import` or `export` declaration to make the
file unambiguously a module (the empty `export {};` declaration
suffices).
* For a script, add the file to the xo overrides section of
package.json that marks it "sourceType": "script", and add a 'use
strict' declaration.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-09 20:04:43 -07:00
Akash Nimare
01f6e77237
macOS: Fix undo redo not working on macOS.
...
The default API provided by Electron doesn't work
as expected. More info here -
https://github.com/electron/electron/issues/15728
Fixes : #866 .
2020-03-10 00:32:05 +05:30
Manav Mehta
7ac35cc087
macOS: Replace deprecated isDarkMode() with shouldUseDarkColors.
...
Fixes : #891 .
2020-03-08 14:55:43 +05:30
Anders Kaseorg
32e6b3054f
xo: Use more xo defaults.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 21:46:18 -08:00
Anders Kaseorg
40bf2a1f20
xo: Lint *.js too.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 21:22:04 -08:00
Anders Kaseorg
dee2f05ac0
locale-helper: Move supported-locales.js to supported-locales.json.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 20:45:57 -08:00
Anders Kaseorg
ca5de73155
xo: Reenable several easy rules.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 20:15:01 -08:00
Anders Kaseorg
d0f8c040c7
package.json: Add tsc to test script.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 18:26:06 -08:00
Anders Kaseorg
7cf40f1e08
typescript: One more switch to ES export syntax.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 18:15:42 -08:00
Anders Kaseorg
598c0df60b
package.json: Reformat to match npm generated output.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 17:52:10 -08:00
Anders Kaseorg
d3bcd7306a
typescript: Switch to ES import/export syntax.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 17:21:03 -08:00
Anders Kaseorg
b3261bcdff
js: Explode more singleton classes to modules.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 16:27:44 -08:00
Manav Mehta
20c6f487c4
typescript: Implement some TODOs.
2020-03-04 14:21:25 -08:00
Anders Kaseorg
340797ca10
typescript: Refine some type annotations to avoid any.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 12:12:31 -08:00
Anders Kaseorg
220aac2d54
js: Explode singleton classes to modules.
...
Singleton classes may have a purpose. This was not that purpose.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 11:54:45 -08:00
Akash Nimare
d9f6cf4cc9
docs: Update recommended node version for development.
2020-03-04 16:59:21 +05:30
Anders Kaseorg
dc3e5d4930
package.json: Sort xo overrides.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 21:50:02 -08:00
Anders Kaseorg
fc2b80c36a
main: Fix realm icon updating.
...
Commit c937317ecf (#605 ) should have
updated this, but didn’t.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 21:50:02 -08:00
Anders Kaseorg
ab667d8053
checkCertError: Fix showMessageBox usage.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 21:50:02 -08:00
Manav Mehta
8b9a10a23d
Update report issue placeholder.
...
Fixes : #873 .
2020-03-04 11:16:31 +05:30
Anders Kaseorg
15af3e732f
sentry-util: Hard-code the Sentry DSN.
...
Commit 088ddf9c62 (#755 ) does not work,
because neither the .env file nor the environment variables it
provides are available to normal users at runtime. This silently
broke Sentry data collection. When we upgraded @sentry/electron in
commit 107e522914 , the silent failure
became an error that prevented the app from starting.
The Sentry DSN is not a secret, so we should just commit it to the
repository.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-04 11:07:00 +05:30
am2505
534f4c1463
Convert Promise to async-await.
...
Fixes #878 .
2020-03-03 20:40:10 -08:00
Anders Kaseorg
063324550e
run-dev: Fix for one package.json structure.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 20:00:36 -08:00
Anders Kaseorg
268471df6b
typings: Remove redundant ZulipWebWindow.$.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 18:17:13 -08:00
Anders Kaseorg
ca6b2312be
typings: Get Window.Notification from upstream.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 18:16:01 -08:00
Anders Kaseorg
ff026e5763
typings: Get NotificationOptions.silent from upstream.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 18:14:13 -08:00
Anders Kaseorg
8f810481e3
typings: Get requestIdleCallback from DefinitelyTyped.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 18:13:26 -08:00
Anders Kaseorg
f91e95647a
typings: Use type declarations from DefinitelyTyped.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 18:01:24 -08:00
Anders Kaseorg
e9536f247b
dependencies: Use one package.json structure.
...
The two package.json structure is no longer needed.
https://www.electron.build/tutorials/two-package-structure
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 11:02:59 -08:00
Anders Kaseorg
067cbf32a1
build: Fix cld sources exclusion.
...
As of commit 107e522914 , @paulcbetts/cld
was renamed to cld.
docs is not being included anyway since it’s outside of app.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-03 10:59:41 -08:00
Anders Kaseorg
6824978114
dependencies: Remove @types/dotenv compatibility stub.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-02 20:31:20 -08:00
Anders Kaseorg
fa86f1ca25
dependencies: Upgrade everything to latest.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-02 20:31:19 -08:00
Anders Kaseorg
a63b3873ae
dependencies: Remove electron-debug.
...
We already implement all of its functionality.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-02 20:15:43 -08:00
Anders Kaseorg
5064ea4b47
dependencies: Upgrade node-json-db from 0.9.2 to 1.0.3.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-02 19:52:39 -08:00
Anders Kaseorg
6b0d8520c5
dependencies: Remove unused dependencies assert, cp-file, is-ci.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-02 19:19:37 -08:00
Anders Kaseorg
4b16164155
cleanup: Remove unused tests/e2e directory.
...
It is not used even by test-e2e.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-02 19:18:25 -08:00
Anders Kaseorg
6036a44fb2
new-server-form: Remove useless .server-save-action wrappers.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-02 19:08:45 -08:00
Anders Kaseorg
598b96b6e8
webview: Wait for dom-ready before sending messages.
...
Fixes tests/test-add-organization.js.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-02 18:52:37 -08:00
Anders Kaseorg
675bc2f06c
appveyor.yml, .travis.yml: Test current Node.js releases.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-03-02 16:30:12 -08:00
Tim Abbott
eb2988a5e4
dependencies: Update typescript and typescript-eslint.
...
The changes are mostly done via `xo --fix`; the other changes are
either trivial or disabling new linter rules that we plan to address
in future commits.
2020-02-29 23:39:55 -08:00
Tim Abbott
39ea18228c
dependencies: Update gulp testing packages.
2020-02-29 22:54:50 -08:00
Tim Abbott
909e0f07e3
dependencies: Upgrade linters and fix linter errors.
...
The changes here are mostly straightforward; the one exception is
removing a zulipdev.org hack.
We disable some lint rules we'll want to address later (E.g. we want
to switch to using async/await rather than .then()). But those are
out of scope for this commit.
2020-02-29 22:47:42 -08:00
Tim Abbott
31af6596bf
dependencies: Upgrade Electron to version 8.
...
This is the latest Electron release, which means we're now getting
nearly modern Chrome (hopefully with fewer rendering bugs and better
performance).
2020-02-29 21:49:19 -08:00
Tim Abbott
3c9914542f
badge: Clear badge counts on Linux as well.
...
My Linux desktop environment doesn't display unread badges, it seems,
but this is clearly how this code should read.
2020-02-29 21:39:56 -08:00
Tim Abbott
f4b9605742
electron: Update some setter/getters to user newer properties.
...
This removes a few deprecation warnings on app startup.
2020-02-29 21:39:56 -08:00
Tim Abbott
e2fc9241fa
dependencies: Upgrade to Electron 7.
...
This works without any other changes, thanks to Electron's deprecation
process being done over multiple releases.
2020-02-29 21:39:56 -08:00