paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-03 05:23:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,092 Commits 27 Branches 70 Tags
c08bbf49ab257ba2303d8e2f81cc6a588fbe357b
Commit Graph

165 Commits

Author SHA1 Message Date
Anders Kaseorg
d661895545 Remove the insecure ignoreCerts option. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-13 04:06:50 -07:00
Anders Kaseorg
22d7ef5615 main: Turn electron-connect off by default. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-06 16:58:25 -07:00
Anders Kaseorg
983254c310 CVE-2020-12637: Do not ignore certificate errors without ignoreCerts. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-05 12:54:35 -07:00
Anders Kaseorg
b6059077d8 Generalize permission-response mechanism to renderer-callback. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-05 12:54:35 -07:00
Anders Kaseorg
34e2b3a3d0 typescript: Eradicate most any annotations. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-04 01:08:05 -07:00
Anders Kaseorg
6b7cce0366 ServerManagerView: Convert loading from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-03 19:16:05 -07:00
Anders Kaseorg
73fec72e6d registerIpcs: Convert webviewListeners to array with functions. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-03 19:09:22 -07:00
Manav Mehta
98174fdcaf help: Update Help Center URL. 
Earlier the menu option used to redirect to *.zulipchat.com/help which is already reachable from the webapp.
This will enable the desktop app to redirect only to zulipchat.com/help instead of the help page of the corresponding organization.

Fixes: #948.
 2020-05-02 20:17:25 +05:30
Anders Kaseorg
d9afee3330 ServerManagerView: Convert functionalTabs from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
a46f2ed618 xo: Enable import/no-mutable-exports. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
fb800f7862 xo: Enable @typescript-eslint/no-unused-vars. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
ba191c3699 xo: Enable object-curly-spacing. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
e49a880ed6 xo: Enable capitalized-comments. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
4bfa7c9265 xo: Enable no-else-return. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
963c2e5388 xo: Enable @typescript-eslint/restrict-plus-operands. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
fc6ff83485 xo: Enable no-alert. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
5ae2a717fa xo: Enable padding-line-between-statements. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
cfdc08a038 xo: Enable unicorn/catch-error-name. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
bb88a7b7a8 xo: Handle floating promises. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
0225778050 typescript: Annotate queueDomain. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
2e03f779e8 typescript: Annotate setMenu props. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Manav Mehta
16f0af8853 Remove storing of User-Agent on disk. 
Fixes: #921.

Co-authored-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-26 13:30:39 -07:00
am2505
bb6d90671f typescript: Complete most TypeScript todos. 2020-04-25 15:49:10 -07:00
Anders Kaseorg
92fb176f67 Revert "auth: Move social login process to browser." 
This reverts commit 49b29bfed6 (#863).

The design of this feature is still under discussion; we expect it to
return after the security release.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
a03f569af9 CVE-2020-10857: Whitelist safe URL protocols for shell.openExternal. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
4390966a62 Always show downloaded files in file manager. 
shell.openItem is unsafe.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
a6d942fe6c CVE-2020-10858: Lock down session permission requests. 
This fixes a vulnerability reported by Matt Austin.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
55eb768064 xo: Upgrade xo to 0.28. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-23 16:53:14 -07:00
Anders Kaseorg
611932c66d xo: Unabbreviate variable names. 
To satisfy unicorn/prevent-abbreviations in xo 0.28.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-23 16:53:12 -07:00
Anders Kaseorg
9d2739f050 js: Declare 'use strict' on all scripts and no modules. 
And enable the import/unambiguous ESLint rule as a check on our
partition between scripts and modules.  After this commit, if you add
a new file and get this error:

  ✖  1:1  This module could be parsed as a valid script.  import/unambiguous

* For a module, add an `import` or `export` declaration to make the
  file unambiguously a module (the empty `export {};` declaration
  suffices).
* For a script, add the file to the xo overrides section of
  package.json that marks it "sourceType": "script", and add a 'use
  strict' declaration.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-09 20:04:43 -07:00
Akash Nimare
01f6e77237 macOS: Fix undo redo not working on macOS. 
The default API provided by Electron doesn't work
as expected. More info here -
https://github.com/electron/electron/issues/15728

Fixes: #866.
 2020-03-10 00:32:05 +05:30
Anders Kaseorg
ca5de73155 xo: Reenable several easy rules. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 20:15:01 -08:00
Anders Kaseorg
d3bcd7306a typescript: Switch to ES import/export syntax. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 17:21:03 -08:00
Anders Kaseorg
b3261bcdff js: Explode more singleton classes to modules. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 16:27:44 -08:00
Anders Kaseorg
340797ca10 typescript: Refine some type annotations to avoid any. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 12:12:31 -08:00
Anders Kaseorg
fc2b80c36a main: Fix realm icon updating. 
Commit c937317ecf (#605) should have
updated this, but didn’t.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-03 21:50:02 -08:00
am2505
534f4c1463 Convert Promise to async-await. 
Fixes #878.
 2020-03-03 20:40:10 -08:00
Anders Kaseorg
598b96b6e8 webview: Wait for dom-ready before sending messages. 
Fixes tests/test-add-organization.js.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-02 18:52:37 -08:00
Tim Abbott
eb2988a5e4 dependencies: Update typescript and typescript-eslint. 
The changes are mostly done via `xo --fix`; the other changes are
either trivial or disabling new linter rules that we plan to address
in future commits.
 2020-02-29 23:39:55 -08:00
Tim Abbott
909e0f07e3 dependencies: Upgrade linters and fix linter errors. 
The changes here are mostly straightforward; the one exception is
removing a zulipdev.org hack.

We disable some lint rules we'll want to address later (E.g. we want
to switch to using async/await rather than .then()).  But those are
out of scope for this commit.
 2020-02-29 22:47:42 -08:00
Tim Abbott
c4beedf740 proxy: Migration to use async/await. 
This is required for the upgrade to Electron 7, which removes the old
callback-based form of these APIs.
 2020-02-29 21:39:56 -08:00
vsvipul
107e522914 deps: Update Electron and related packages to Electron v6. 
This updates most of our direct dependencies to much newer versions
(Electron v6, with compatible versions of related packages like
Spectron).

Further, it updates all of our recursive dependencies with `npm update
--depth=999`.

Modified by tabbott to migrate to async/await for dialogs rather than
the old synchronous API.
 2020-02-29 18:28:42 -08:00
ViPuL
49b29bfed6 auth: Move social login process to browser. 
Moves the social login to browser since there
was no way to verify the authencity of the
auth process for a custom server and to
prevent phishing attacks.

Fixes #849.

Co-authored-by: Kanishk Kakar <kanishk.kakar@gmail.com>
 2020-02-25 20:05:27 +05:30
Ross Brunton
9582d32de8 Added option to select download locations. 
Added an option that, when enabled, will mean any file downloads that
would normally go to ~/Downloads (or wherever), in fact prompt.
 2020-01-21 16:41:56 +05:30
ViPuL
a2a21631f2 Decode server name in Window menu. 2020-01-08 11:58:44 +05:30
Ross Brunton
eb1be7106b Added option to quit on closing the window. 
This adds a configuration option to quit the app (rather than going to
the tray) when the "close" button is clicked.
 2019-10-14 01:05:18 +05:30
Muskan Khedia
30b40e2ff2 network: Prompts Desktop App to ask for network setting in add-org page. 
Fixes: #540.
 2019-09-28 17:44:34 +05:30
Kanishk Kakar
8446deb673 sidebar: Improve UX for notification settings. 
* sidebar: Disable notif settings if not logged in.

* sidebar: Activate relevant tab for notif settings.
 2019-09-25 18:25:00 +05:30
Kanishk Kakar
d4b9663257 network: Tackle network issues independently. 
Few changes -
* webview: Show connection failure per server.
* network: Try to reconnect diff servers.
* Fixes concern that some proxy networks may allow only specific servers
to be reachable.
* domains: Show network error on server invalidation.
* webview: Handle network errors in preload script.
Fixes: #591, #312.
 2019-09-24 18:22:19 +05:30
Kanishk Kakar
177b77f0b5 sidebar: Add option to open notification setting from the context menu. 2019-09-15 21:20:08 +05:30