paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-15 19:31:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,777 Commits 27 Branches 70 Tags
e89f44c87fc0cbd00c20bf12a1a8ee067756dce0
Commit Graph

758 Commits

Author SHA1 Message Date
Anders Kaseorg
79808e8ee9 preload: Provide hooks for server to robustly replace logout et al. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 18:11:45 -08:00
Anders Kaseorg
2c38df10c8 electron-bridge: Expose boolean return from emit. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 17:59:59 -08:00
Anders Kaseorg
1ca15d44a0 electron-bridge: Move mutable state out of electron_bridge. 
Only the initial value of a mutable field is exposed via
exposeInMainWorld, which is why we have a bunch of setter and getter
functions.  It’s better to avoid the possibility for this confusion.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 17:54:21 -08:00
Anders Kaseorg
82450a91a9 preload: Remove retry button redirection hack. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 17:18:09 -08:00
Anders Kaseorg
62edfa6f8b Remove macOS notification inline replies feature. 
node-mac-notifier no longer builds on macOS with Electron 11 (error:
no template named 'remove_cv_t' in namespace 'std').  It was
previously implicated in crashes on macOS (#1016).  And we no longer
have any macOS developers that seem to be maintaining this
feature (e.g. #1022 is stalled).

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 17:06:11 -08:00
Anders Kaseorg
df3f719e89 Upgrade dependencies, including Electron 11.0.3. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 16:02:41 -08:00
Anders Kaseorg
0632d8199f injected: Condition narrow-by-topic handler on page_params. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 16:02:32 -08:00
Anders Kaseorg
047bf0ca45 webview: Pass webPreferences values as explicit booleans 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-11-30 12:39:35 -08:00
Anders Kaseorg
ba432d32b3 Remove preventdrag script. 
This was not a security feature; security is enforced using context
isolation and the same-origin policy.

Furthermore, navigation on drag-and-drop was already disabled by
default in Electron 3.0.

https://www.electronjs.org/blog/electron-3-0#breaking-api-changes

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-11-17 16:10:47 -08:00
aryanshridhar
cd77fc6448 new-server-form: Strip whitespace from added organization URL. 
Fixes #1037.
 2020-11-15 19:56:53 -08:00
Anders Kaseorg
73710319e6 xo: Fix unicorn/prevent-abbreviations. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
da91dc5595 xo: Fix @typescript-eslint/consistent-indexed-object-style. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
31d5e5a092 xo: Fix unicorn/prefer-ternary, I guess. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
13ee1d0990 logger-util: Add missing space. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
d5a9063378 typescript: Fix implicit any in catch clauses. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
918064f35d checkDomain: Remove special handling for “certificate” error strings. 
The fragile check has been broken by changing strings, and the default
invalidZulipServerError message is fine.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:01 -07:00
Anders Kaseorg
193b8326bc injected: Check if narrow is defined. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:32:05 -07:00
Anders Kaseorg
9abb7f376e injected: Remove unused default_language from zulipWindow type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:32:05 -07:00
Aryan Shridhar
126bb26a6e Tray Icon : Changed Unread tray icon in Windows. 
Replaced unread messages icon in the lower tray bar in windows with a new icon.
Fixed #506.
 2020-09-17 16:07:23 +05:30
Anders Kaseorg
23e86abb5b Remove support for custom certificate exceptions. 
Version 5.4.0 and later uses electron.net for all network
requests (#993), so custom certificates can now be configured in the
same system certificate store that Chrome uses.

https://zulip.com/help/custom-certificates#desktop

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-11 22:25:28 -07:00
Anders Kaseorg
97f8fe71af Escape all strings inserted into CSS selectors. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:42 -07:00
Anders Kaseorg
a9d59b3dcd CVE-2020-24582: Escape all strings interpolated into HTML. 
Also fix various variable names to consistently indicate which strings
contain HTML.

Some of these changes close cross-site scripting vulnerabilities, and
others are for consistency.  It’s important to be meticulously
consistent about escaping so that changes that would introduce
vulnerabilities stand out as obviously wrong.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:38 -07:00
Anders Kaseorg
c302ebe282 general-section: Convert .filter(…)[0] to .find(…). 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-25 15:40:40 -07:00
Anders Kaseorg
0f1245b975 Upgrade dependencies, including Electron 9. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 01:37:41 -07:00
Anders Kaseorg
960312a932 notification: Move loadBots call to preload, to break an import cycle. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 01:37:07 -07:00
Anders Kaseorg
ec205f68a6 Send only needed data from tabs over IPC. 
Fixes exceptions from the structured clone algorithm raised by
Electron 9.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-24 00:39:38 -07:00
Anders Kaseorg
5fe5989710 xo: Enable import/newline-after-import. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-23 23:18:25 -07:00
Anders Kaseorg
69141b5395 Remove spurious 'use-strict' [sic] directives. 
The directive is 'use strict'.  It’s not necessary in TypeScript.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-23 23:09:12 -07:00
Anders Kaseorg
8d66f05924 xo: Sort imports with import/order. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-23 23:06:41 -07:00
Manav Mehta
14a1f5d3e1 request: Replace deprecated request module with net.request. 
Co-authored-by: Anders Kaseorg <anders@zulip.com>

Fixes: #886.
 2020-07-14 15:50:52 +05:30
Anders Kaseorg
9cf26f4890 dependencies: Upgrade dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-01 15:01:47 -07:00
Anders Kaseorg
397a7381b8 main: Use import() syntax for electron-connect. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-01 15:01:38 -07:00
Anders Kaseorg
24b28f9ded proxy-util: Fix misuse of void. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-01 15:01:29 -07:00
Anders Kaseorg
9ceabe02d5 Use optional catch binding. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-01 15:01:29 -07:00
Manav Mehta
e97ab2e6dd Replace deprecated getWebContents API 2020-06-30 20:33:41 -07:00
Anders Kaseorg
b6e11f623a darwin-notifications: Avoid no-useless-return warnings. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-26 18:56:07 -07:00
Anders Kaseorg
1c60c335fd logger-util: Avoid no-fallthrough warnings. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-26 18:56:03 -07:00
Anders Kaseorg
c9249b1724 context-menu: Avoid no-unnecessary-boolean-literal-compare warning. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-26 15:56:23 -07:00
Anders Kaseorg
9e957ba704 context-menu: Copy the email address, not the link text. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-26 15:47:38 -07:00
Abhigyan Khaund
addfe2e414 context-menu: Remove trailing and leading separators when not required. 
Fixes: #979.
 2020-06-27 02:38:03 +05:30
Abhigyan Khaund
bda0dd29df context-menu: Fix bug in Copy Link and add copy Email. 
Fixes: #986
 2020-06-27 02:27:44 +05:30
Abhigyan Khaund
01926e1234 context-menu: Enable copy only when copy is possible. 2020-06-27 02:27:44 +05:30
Manav Mehta
0fff6336c7 spellchecker: Use Electron 8 built-in spellchecker. 
* Using electron built-in spellchecker
* Added the custom context menu

Co-authored-by: Anders Kaseorg <anders@zulipchat.com>

Fixes: #504
 2020-06-18 18:14:23 +05:30
Akash Nimare
f976270d33 lint: Fix linting errors. 2020-06-17 01:44:08 +05:30
Akash Nimare
2f70621255 windows: Turn off start at login by default. 
Fixes: #960.
 2020-06-16 20:10:23 +05:30
Manav Mehta
25f4c3aba8 translations: Prevent i18n to automatically add strings. 
Now that we have moved to Transifex, auto updation of translation strings is not required.
We would only need to update the resource file (en.json) and push it to Transifex and pulling the rest <lang>.json
 2020-06-12 13:18:04 +05:30
Anders Kaseorg
1b23468375 Update zulipchat.com emails to zulip.com. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-08 14:02:08 -07:00
Anders Kaseorg
5d775405d9 Update zulipchat.com links to zulip.com. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-08 14:01:40 -07:00
Anders Kaseorg
99a3530238 xo: Add arrow-body-style rule 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-26 11:25:24 -07:00
Manav Mehta
a5ceffc856 transifex: Setup Transifex for better translation process. 2020-05-20 22:11:13 +05:30