* Browser-like loading indicator added to the sidebar.
Shows when the app is loading a page. Inactive once the user starts
navigating on the webpage, and in settings.
* Add tooltip saying "Loading" to indicator.
Fixes#430.
* Add View menu shortcut to hide menu bar
The hide menu bar setting available in General Preferences has been added to the View menu.
* settings: Add method to coordinate menu & settings
Use autoHideMenuBar setting with said method.
This PR removes .ogg file check (supported only by very old servers). Other enhancements in server validation logic -
* Reject domains with no organizations.
* Convert validation methods to async await
* Add messages.js for returning error message strings.
Fixes: #596, #573.
Adds an option to enable or disable sentry error
reporting under Advanced section in General Settings.
Handles both main and renderer processes.
Also, changes the domain used to resolve proxy
in proxy-util from google.com to example.com.
Fixes#702.
This is an experimental fix for spellchecker. Previously, we were only using this on macOS since on other platforms, the spellcheck-module claimed to auto-detect + switch language on the fly but looks like it's not working as expected.
Addresses the issue of the webview not being in focus
after the Back button is clicked. Now, the webview is focused
explicitly by calling focus() on click.
Numpad keys by default aren't supported by electron
for using in menu accelarators. Uses a workaround to
make zoom options work with Numpad keys.
Fixes: #344.
This commit works around a couple of bugs, which seem to be upstream bugs in the
current version of Electron.
First, `webContents.isFocused()` seems to be true even if we just switched to
a tab, and are trying to set it as the focused element. To work around this, we
check if the `webview` element is the same as `document.activeElement`.
Also, as per https://github.com/electron/electron/issues/15718, it looks like
`blur` needs to be called on the currently active element, before switching
focus on another element i.e., calling `focus` on it.
Fixes: #634.
* Adds a new option to the Window menu that allows users to change to the
next organization cyclically. Activated by Ctrl + Tab.
* Switch to the previous server on Ctrl + Shift + Tab.
In certain requests like for fetching realm icons, request tries to verify server certificate and fails when the user has chosen to ignore cert warnings and has not uploaded the cert.
In those cases, we should mark that this server verification is ignored and ask request to ignore the cert verification bypassing that parameter.
Fixes#684.
Addresses a problem where the context menu would get the incorrect index
of server in sidebar and cause a crash when attempting to remove the
server.
Add comment justifying extra index parameter.
We should ensure backward compatibilty when using narrow.by_topic since
the recent rename in the webapp of the function narrow.by_subject to
narrow.by_topic is only in master and not in any stable release yet it
could break the notification function for many people. Furthermore this ensure
general backward-compatibilty.
* dependecies: Upgrade electron to v3.0.10.
This also makes sure we don't pass properties on this.tabs
that makes ipcRenderer crash on v3.x.x.
* tray: Use new way for using nativeImage.createFromBuffer.
The previous way of passing scaleFactor as a second argument
is now deprecated and will be a breaking change in 4.0
* app: Use new requestSingleInstanceLock api and remove deceprated makeSingleInstance.
* Update node-mac-notifier to v1.1.0.
Two changes -
* Fixes the context menu not working on adding a new org. This is
because previously the context menu listner only called when loading
the app. Updated the same to fix the issue.
* Refactor the codebase for left-sidebar.
Improves #599.
This adds a context menu in the left sidebar. For now, there is one sub-item called - Disconnect organization by which a user can delete an added org from the app.
Fixes: #599.
The HTTP Node now uses auto for ecdhCurve for SSL connections. This fixes the SSL
handshake error while connecting to some Zulip instances. Setting the ecdhCurve to auto
is the recommended method for Node > 8.5, more info here -
https://github.com/nodejs/node/issues/16196Fixes: #594.
This PR adds a functionality to update the menu items.
Some menu items like logout, shortcut etc are not needed
on setting page. We can control the same using this flag.
Fixes: #587.
