paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-02 13:03:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,556 Commits 27 Branches 70 Tags
fc6ff83485ce8f85031684c340278bb744229b1f
Commit Graph

628 Commits

Author SHA1 Message Date
Anders Kaseorg
fc6ff83485 xo: Enable no-alert. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
5ae2a717fa xo: Enable padding-line-between-statements. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
cfdc08a038 xo: Enable unicorn/catch-error-name. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
b76467529d xo: Upgrade xo to 0.30. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
bb88a7b7a8 xo: Handle floating promises. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
0225778050 typescript: Annotate queueDomain. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
2154b191c8 typescript: Annotate url in WebviewProps. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
2e03f779e8 typescript: Annotate setMenu props. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Manav Mehta
16f0af8853 Remove storing of User-Agent on disk. 
Fixes: #921.

Co-authored-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-26 13:30:39 -07:00
am2505
bb6d90671f typescript: Complete most TypeScript todos. 2020-04-25 15:49:10 -07:00
Akash Nimare
340eb8da99 server-icon: Handle server icon update gracefully. 
Don't trigger user-facing network error for updating the server icon.
 2020-04-24 11:48:27 +05:30
Anders Kaseorg
ae689ad6bb general-section: Import supported-locales.json as a JSON module. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-22 13:06:00 -07:00
Anders Kaseorg
7ffddded5d Configure language by value, not by index. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-22 13:05:59 -07:00
Anders Kaseorg
714cd926ae generateSelectTemplate: Add missing HTML escaping. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-22 13:05:15 -07:00
Manav Mehta
b2f4af0f49 Add feature to set application language. 
User can now select application language without changing the language in the operating system.

Fixes: #855.
 2020-04-22 18:08:49 +05:30
Anders Kaseorg
92fb176f67 Revert "auth: Move social login process to browser." 
This reverts commit 49b29bfed6 (#863).

The design of this feature is still under discussion; we expect it to
return after the security release.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
a03f569af9 CVE-2020-10857: Whitelist safe URL protocols for shell.openExternal. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
af59bb7c99 handleExternalLink: Do not navigate the current window. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
4390966a62 Always show downloaded files in file manager. 
shell.openItem is unsafe.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
a6d942fe6c CVE-2020-10858: Lock down session permission requests. 
This fixes a vulnerability reported by Matt Austin.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
9d4093b3d8 CVE-2020-10856: Enable context isolation. 
This fixes a vulnerability reported by Matt Austin.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
20a6c5d128 preload: Use IPC for logout, shortcut, showNotificationSettings. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
c843e179fc tray: Remove tray variable from window. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
438d4fffa7 notification: Convert loadBots from jQuery to fetch. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:32:23 -07:00
Tim Abbott
5c164bfa7d webview: Disable insecure content. 
Zulip servers in production are designed to only serve content over
HTTPS.  And a development environment's root page will be served over
HTTP.

So there is no purpose in enabling allowInsecureContent, even
conditionally for use against Zulip development environments; we should
just remove the setting.
 2020-03-30 19:32:23 -07:00
Anders Kaseorg
cbc89a72a2 tray: Work around Electron segfault on certain platforms. 
Set the tray icon’s context menu immediately after creating the Tray
object.  This seems to prevent an Electron segfault at startup on
certain platforms, such as Ubuntu 16.04 i386.  See
https://github.com/electron/electron/issues/22652 and its linked
issues.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:26:29 -07:00
Anders Kaseorg
55eb768064 xo: Upgrade xo to 0.28. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-23 16:53:14 -07:00
Anders Kaseorg
611932c66d xo: Unabbreviate variable names. 
To satisfy unicorn/prevent-abbreviations in xo 0.28.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-23 16:53:12 -07:00
Anders Kaseorg
9d2739f050 js: Declare 'use strict' on all scripts and no modules. 
And enable the import/unambiguous ESLint rule as a check on our
partition between scripts and modules.  After this commit, if you add
a new file and get this error:

  ✖  1:1  This module could be parsed as a valid script.  import/unambiguous

* For a module, add an `import` or `export` declaration to make the
  file unambiguously a module (the empty `export {};` declaration
  suffices).
* For a script, add the file to the xo overrides section of
  package.json that marks it "sourceType": "script", and add a 'use
  strict' declaration.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-09 20:04:43 -07:00
Akash Nimare
01f6e77237 macOS: Fix undo redo not working on macOS. 
The default API provided by Electron doesn't work
as expected. More info here -
https://github.com/electron/electron/issues/15728

Fixes: #866.
 2020-03-10 00:32:05 +05:30
Manav Mehta
7ac35cc087 macOS: Replace deprecated isDarkMode() with shouldUseDarkColors. 
Fixes: #891.
 2020-03-08 14:55:43 +05:30
Anders Kaseorg
ca5de73155 xo: Reenable several easy rules. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 20:15:01 -08:00
Anders Kaseorg
7cf40f1e08 typescript: One more switch to ES export syntax. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 18:15:42 -08:00
Anders Kaseorg
d3bcd7306a typescript: Switch to ES import/export syntax. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 17:21:03 -08:00
Anders Kaseorg
b3261bcdff js: Explode more singleton classes to modules. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 16:27:44 -08:00
Manav Mehta
20c6f487c4 typescript: Implement some TODOs. 2020-03-04 14:21:25 -08:00
Anders Kaseorg
340797ca10 typescript: Refine some type annotations to avoid any. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 12:12:31 -08:00
Anders Kaseorg
220aac2d54 js: Explode singleton classes to modules. 
Singleton classes may have a purpose.  This was not that purpose.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 11:54:45 -08:00
Anders Kaseorg
fc2b80c36a main: Fix realm icon updating. 
Commit c937317ecf (#605) should have
updated this, but didn’t.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-03 21:50:02 -08:00
Anders Kaseorg
ab667d8053 checkCertError: Fix showMessageBox usage. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-03 21:50:02 -08:00
Manav Mehta
8b9a10a23d Update report issue placeholder. 
Fixes: #873.
 2020-03-04 11:16:31 +05:30
Anders Kaseorg
15af3e732f sentry-util: Hard-code the Sentry DSN. 
Commit 088ddf9c62 (#755) does not work,
because neither the .env file nor the environment variables it
provides are available to normal users at runtime.  This silently
broke Sentry data collection.  When we upgraded @sentry/electron in
commit 107e522914, the silent failure
became an error that prevented the app from starting.

The Sentry DSN is not a secret, so we should just commit it to the
repository.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 11:07:00 +05:30
am2505
534f4c1463 Convert Promise to async-await. 
Fixes #878.
 2020-03-03 20:40:10 -08:00
Anders Kaseorg
f91e95647a typings: Use type declarations from DefinitelyTyped. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-03 18:01:24 -08:00
Anders Kaseorg
5064ea4b47 dependencies: Upgrade node-json-db from 0.9.2 to 1.0.3. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-02 19:52:39 -08:00
Anders Kaseorg
6036a44fb2 new-server-form: Remove useless .server-save-action wrappers. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-02 19:08:45 -08:00
Anders Kaseorg
598b96b6e8 webview: Wait for dom-ready before sending messages. 
Fixes tests/test-add-organization.js.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-02 18:52:37 -08:00
Tim Abbott
eb2988a5e4 dependencies: Update typescript and typescript-eslint. 
The changes are mostly done via `xo --fix`; the other changes are
either trivial or disabling new linter rules that we plan to address
in future commits.
 2020-02-29 23:39:55 -08:00
Tim Abbott
909e0f07e3 dependencies: Upgrade linters and fix linter errors. 
The changes here are mostly straightforward; the one exception is
removing a zulipdev.org hack.

We disable some lint rules we'll want to address later (E.g. we want
to switch to using async/await rather than .then()).  But those are
out of scope for this commit.
 2020-02-29 22:47:42 -08:00
Tim Abbott
3c9914542f badge: Clear badge counts on Linux as well. 
My Linux desktop environment doesn't display unread badges, it seems,
but this is clearly how this code should read.
 2020-02-29 21:39:56 -08:00