From 003d086f2e6479804092ecf27ba3ff09a5824b2e Mon Sep 17 00:00:00 2001 From: Mateusz Mandera Date: Sun, 27 Mar 2022 20:43:01 +0200 Subject: [PATCH] sessions: Only fetch user ids in delete_realm_user_sessions. No need to fetch entire UserProfiles, especially since we're dealing with all UserProfiles in a Realm here, which would be quite large. --- zerver/lib/sessions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zerver/lib/sessions.py b/zerver/lib/sessions.py index d68e2f1982..e713780a0c 100644 --- a/zerver/lib/sessions.py +++ b/zerver/lib/sessions.py @@ -47,7 +47,7 @@ def delete_user_sessions(user_profile: UserProfile) -> None: def delete_realm_user_sessions(realm: Realm) -> None: - realm_user_ids = [user_profile.id for user_profile in UserProfile.objects.filter(realm=realm)] + realm_user_ids = list(UserProfile.objects.filter(realm=realm).values_list("id", flat=True)) for session in Session.objects.filter(expire_date__gte=timezone_now()): if get_session_user(session) in realm_user_ids: delete_session(session)