paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

reactions: Deduplicate shared code.

Browse Source 
Creates a function for code shared by update_user_fields
and make_clean_reaction.
This commit is contained in:
evykassirer
2024-03-05 10:43:44 -08:00
committed by Tim Abbott
parent 2de1486719
commit 0062d3f999
2 changed files with 47 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
web/tests/reactions.test.js
View File

@@ -1177,6 +1177,22 @@ test("remove_reaction_from_view (last person)", () => {
assert.ok(removed);
});
test("bogus_event", ({override}) => {
// We don't expect errors when we process events with
// bad message ids.
override(message_store, "get", noop);
const bogus_event = {
message_id: 55,
reaction_type: "realm_emoji",
emoji_name: "realm_emoji",
emoji_code: "991",
user_id: 99,
};
reactions.add_reaction(bogus_event);
reactions.remove_reaction(bogus_event);
});
test("remove spurious user", ({override}) => {
// get coverage for removing non-user (it should just
// silently fail)