paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Make acting_user a mandatory kwarg for do_set_realm_notifications_stream.

Browse Source
This commit is contained in:
shanukun
2021-03-08 09:54:00 +05:30
committed by Tim Abbott
parent 0267ba54b2
commit 00d998b955
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
zerver/lib/actions.py
View File

@@ -908,10 +908,7 @@ def do_set_realm_message_editing(
def do_set_realm_notifications_stream(
realm: Realm,
stream: Optional[Stream],
stream_id: int,
acting_user: Optional[UserProfile] = None,
realm: Realm, stream: Optional[Stream], stream_id: int, *, acting_user: Optional[UserProfile]
) -> None:
old_value = realm.notifications_stream_id
realm.notifications_stream = stream

5
zerver/tests/test_events.py
View File

@@ -1152,7 +1152,10 @@ class NormalActionsTest(BaseAction):
for notifications_stream, notifications_stream_id in ((stream, stream.id), (None, -1)):
events = self.verify_action(
lambda: do_set_realm_notifications_stream(
self.user_profile.realm, notifications_stream, notifications_stream_id
self.user_profile.realm,
notifications_stream,
notifications_stream_id,
acting_user=None,
)
)
check_realm_update("events[0]", events[0], "notifications_stream_id")