paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

sidebars: Remove unnecessary opaque color variant.

Browse Source 
There is no longer any opacity in the
--color-background-hover-narrow-filter, so the opaque
variant just adds noise and the potential for drift
from the original color.
This commit is contained in:
Karl Stolley
2025-10-02 10:24:32 -05:00
committed by Tim Abbott
parent 023fd27bcb
commit 00e437caa7
2 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/styles/app_variables.css
View File

@@ -769,13 +769,6 @@
hsl(0deg 0% 97%), hsl(0deg 0% 97%),
color-mix(in srgb, hsl(0deg 0% 97%) 8%, hsl(0deg 0% 11%)) color-mix(in srgb, hsl(0deg 0% 97%) 8%, hsl(0deg 0% 11%))
); );
/* We mix an opaque version with the background for
replicating the color on .sidebar-topic-check, which
will mask a portion of the topic-grouping bracket. */
--color-background-opaque-hover-narrow-filter: light-dark(
var(--color-background-hover-narrow-filter),
color-mix(in srgb, hsl(0deg 0% 97%) 8%, hsl(0deg 0% 11%))
);
--color-shadow-sidebar-row-hover: light-dark( --color-shadow-sidebar-row-hover: light-dark(
hsl(0deg 0% 0% / 30%), hsl(0deg 0% 0% / 30%),
hsl(0deg 0% 100% / 30%) hsl(0deg 0% 100% / 30%)
@@ -987,9 +980,8 @@
hsl(18deg 100% 84%), hsl(18deg 100% 84%),
hsl(22deg 70% 35%) hsl(22deg 70% 35%)
); );
--color-buddy-list-highlighted-user: light-dark( --color-buddy-list-highlighted-user: var(
var(--color-background-hover-narrow-filter), --color-background-hover-narrow-filter
var(--color-background-opaque-hover-narrow-filter)
); );
--color-buddy-list-avatar-loading: light-dark( --color-buddy-list-avatar-loading: light-dark(
hsl(0deg 0% 0% / 10%), hsl(0deg 0% 0% / 10%),

6
web/styles/left_sidebar.css
View File

@@ -431,7 +431,7 @@
} }
&:hover { &:hover {
background-color: var(--color-background-opaque-hover-narrow-filter); background-color: var(--color-background-hover-narrow-filter);
box-shadow: inset 0 0 0 1px var(--color-shadow-sidebar-row-hover); box-shadow: inset 0 0 0 1px var(--color-shadow-sidebar-row-hover);
/* We only set the border radius on the hover/popover states, /* We only set the border radius on the hover/popover states,
so as to prevent the background on highlighted channels so as to prevent the background on highlighted channels
@@ -698,9 +698,7 @@
box-shadow: inset 0 0 0 1px var(--color-shadow-sidebar-row-hover); box-shadow: inset 0 0 0 1px var(--color-shadow-sidebar-row-hover);
.sidebar-topic-check { .sidebar-topic-check {
background-color: var( background-color: var(--color-background-hover-narrow-filter);
--color-background-opaque-hover-narrow-filter
);
} }
} }