paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_delete: Sort message_ids when sending delete_message event.

Browse Source 
Fixes #34324.
https://chat.zulip.org/#narrow/channel/412-api-documentation/topic/Make.20message_ids.20from.20message.20update.20event.20sorted
This commit is contained in:
Shubham Padia
2025-06-17 11:04:22 +00:00
committed by Tim Abbott
parent 37bfb7c963
commit 00fe2236da
4 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/tests/test_events.py
View File

@@ -3938,7 +3938,10 @@ class NormalActionsTest(BaseAction):
hamlet = self.example_user("hamlet")
msg_id = self.send_stream_message(hamlet, "Verona")
msg_id_2 = self.send_stream_message(hamlet, "Verona")
messages = [Message.objects.get(id=msg_id), Message.objects.get(id=msg_id_2)]
# Pass messages in reverse sorted order, so we can test that
# the backend is sorting the messages_ids sent in the delete
# event.
messages = [Message.objects.get(id=msg_id_2), Message.objects.get(id=msg_id)]
with self.verify_action(state_change_expected=True) as events:
do_delete_messages(self.user_profile.realm, messages, acting_user=None)
check_delete_message(
@@ -3948,6 +3951,7 @@ class NormalActionsTest(BaseAction):
num_message_ids=2,
is_legacy=False,
)
self.assertEqual(events[0]["message_ids"], sorted(events[0]["message_ids"]))
def test_do_delete_message_stream_legacy(self) -> None:
"""